Move the k8sreporter dump into FailHandler and make dir for the reports #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liornoy
force-pushed
the
change-k8sreporter
branch
5 times, most recently
from
23b37cd
to
97ebb14
Compare
liornoy
changed the title
liornoy
force-pushed
the
change-k8sreporter
branch
from
29765e9
to
bdc802c
Compare
This commit moves the reporter.Dump() call into the FailHandler. We do this because previously, having the reporter dump in the ReportAfterEach, we didn't get the desired logs because the test namesapce would be cleaned beforehand in the AfterEach/ AfterAll phase. Also wee modify the skipCaller to point to the correct line. Signed-off-by: Lior Noy <[email protected]>
This commit makes the k8s reporter to create a dir named "metallb_failure_report.log" to place all the failed tests in it. We ignore the error of dir already exist to allow it to use the same dir for the validation and funcaitonal test suites. Signed-off-by: Lior Noy <[email protected]>
liornoy
force-pushed
the
change-k8sreporter
branch
from
bdc802c
to
9ecbdd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the reporter.Dump() call into the FailHandler. We do this because previously, having the reporter dump in the ReportAfterEach, we didn't get the desired logs because the test namesapce would be cleaned beforehand in the AfterEach/ AfterAll phase.
Also, made the reporter to create a directory named "metallb_failure_report.log" to house all the failed tests from all of the test suites.