Make dir for all of the failed tests

This commit makes the k8s reporter to create a dir named "metallb_failure_report.log" to place all the failed tests in it. We ignore the error of dir already exist to allow it to use the same dir for the validation and funcaitonal test suites. Signed-off-by: Lior Noy <[email protected]>
metallb · Sep 12, 2023 · 9ecbdd2 · 9ecbdd2
1 parent fe1468f
commit 9ecbdd2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/test/e2e/functional/e2e_test.go b/test/e2e/functional/e2e_test.go
@@ -57,7 +57,8 @@ func TestE2E(t *testing.T) {
 
 	if *reportPath != "" {
 		kubeconfig := os.Getenv("KUBECONFIG")
-		r = k8sreporter.New(kubeconfig, *reportPath, OperatorNameSpace)
+		reportPath := path.Join(*reportPath, "metallb_failure_report.log")
+		r = k8sreporter.New(kubeconfig, reportPath, OperatorNameSpace)
 	}
 
 	RunSpecs(t, "Metallb Operator E2E Suite", reporterConfig)

diff --git a/test/e2e/k8sreporter/reporter.go b/test/e2e/k8sreporter/reporter.go
@@ -3,7 +3,9 @@
 package k8sreporter
 
 import (
+	"errors"
 	"log"
+	"os"
 
 	"github.com/openshift-kni/k8sreporter"
 	corev1 "k8s.io/api/core/v1"
@@ -41,6 +43,11 @@ func New(kubeconfig, path, namespace string) *k8sreporter.KubernetesReporter {
 		{Cr: &corev1.ServiceList{}},
 	}
 
+	err := os.Mkdir(path, 0755)
+	if err != nil && !errors.Is(err, os.ErrExist) {
+		log.Fatalf("Failed to create the reporter dir: %s", err)
+	}
+
 	reporter, err := k8sreporter.New(kubeconfig, addToScheme, dumpNamespace, path, crds...)
 	if err != nil {
 		log.Fatalf("Failed to initialize the reporter %s", err)

diff --git a/test/e2e/validation/validation_test.go b/test/e2e/validation/validation_test.go
@@ -56,7 +56,8 @@ func TestValidation(t *testing.T) {
 
 	if *reportPath != "" {
 		kubeconfig := os.Getenv("KUBECONFIG")
-		r = k8sreporter.New(kubeconfig, *reportPath, OperatorNameSpace)
+		reportPath := path.Join(*reportPath, "metallb_failure_report.log")
+		r = k8sreporter.New(kubeconfig, reportPath, OperatorNameSpace)
 	}
 
 	RunSpecs(t, "Metallb Operator Validation Suite", reporterConfig)