Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#9660): update e2e sync function #9659

Merged
merged 11 commits into from
Nov 25, 2024
Merged

chore(#9660): update e2e sync function #9659

merged 11 commits into from
Nov 25, 2024

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Nov 21, 2024

Description

When we sync, and an update comes, the update modal can appear before we see the sync status update to successful, and it will close the sidebar menu when it shows up.
This made e2e sync function retry and spend time on unnecessary waits.
Adds reloadSession common page function.

#9660

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan dianabarsan changed the title chore(n/a): update e2e sync chore(#9660): update e2e sync Nov 21, 2024
@dianabarsan dianabarsan changed the title chore(#9660): update e2e sync chore(#9660): update e2e sync function Nov 21, 2024
@dianabarsan dianabarsan marked this pull request as ready for review November 21, 2024 15:00
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
@dianabarsan dianabarsan merged commit 5157ee9 into master Nov 25, 2024
44 checks passed
@dianabarsan dianabarsan deleted the update-e2e-sync branch November 25, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants