Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(n/a): e2e sync takes a long time because of unnecessary waits #9637

Closed
wants to merge 9 commits into from

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Nov 12, 2024

Description

This started off as a bug fix and then exploded.
I branched of the bug fix and keeping this open to continue later, in a e2e focused PR.

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan
Copy link
Member Author

Hi @latin-panda and @kapelo .
I have this small PR that fixes a bug in the tasks component. I'd appreciate a review and QA assist.

For the QA assist, you will probably need to use a low performance device or tune your browser CPU performance throttling way up. I set it to 20x slowdown to consistently replicate the issue.

Appreciate it!

@dianabarsan
Copy link
Member Author

Ok, it seems like one e2e test is consistently failing. I'll re-request the reviews when I've fixed it.

@dianabarsan dianabarsan marked this pull request as draft November 15, 2024 13:05
@dianabarsan dianabarsan changed the title fix(#9612): show loader in task list immediately after completing a task chode(n/a): e2e sync takes a long time because of unnecessary waits Nov 15, 2024
@dianabarsan dianabarsan changed the title chode(n/a): e2e sync takes a long time because of unnecessary waits chore(n/a): e2e sync takes a long time because of unnecessary waits Nov 15, 2024
@dianabarsan
Copy link
Member Author

Closing in favor of #9659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant