Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure server does not panic when Kill is called #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure server does not panic when Kill is called #55

wants to merge 1 commit into from

Commits on Dec 28, 2018

  1. Ensure server does not panic when Kill is called 

    The datagram channel is closed without synchronization, thus the reading
routine is exposed to a race condition that crashes the channel. As the
crash is sporadic, it's not easily reproducible in test, but sending
multiple packets during shutdown causes the crash.

An alternative solution is do synchronize using a done channel:
https://blog.golang.org/pipelines

Signed-off-by: liron <[email protected]>
    liron committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    e9fc8a3 View commit details
    Browse the repository at this point in the history