Ensure server does not panic when Kill is called #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datagram channel is closed without synchronization, thus the reading routine is exposed to a race condition that crashes the channel. As the crash is sporadic, it's not easily reproducible in test, but sending multiple packets during shutdown causes the crash. An alternative solution is do synchronize using a done channel: https://blog.golang.org/pipelines Signed-off-by: liron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datagram channel is closed without synchronization, thus the reading
routine is exposed to a race condition that crashes the channel. As the
crash is sporadic, it's not easily reproducible in test, but sending
multiple packets during shutdown causes the crash.
An alternative solution is do synchronize using a done channel:
https://blog.golang.org/pipelines
Signed-off-by: liron [email protected]