Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow call as valid subscope for call scoped rules #2490

Merged
merged 1 commit into from
Nov 19, 2024
Merged

allow call as valid subscope for call scoped rules #2490

merged 1 commit into from
Nov 19, 2024

Conversation

mr-tz
Copy link
Collaborator

@mr-tz mr-tz commented Nov 14, 2024

naive fix

questions?

  • does this suffice / result in unwanted side behavior (current tests pass)
  • add new tests?
  • update docs?

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@mr-tz mr-tz mentioned this pull request Nov 14, 2024
Merged
@mr-tz
Copy link
Collaborator Author

mr-tz commented Nov 19, 2024

ran local tests comparing results, so going ahead here

@mr-tz mr-tz merged commit d510743 into master Nov 19, 2024
27 checks passed
@mr-tz mr-tz deleted the call-subscope branch November 19, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williballenthin williballenthin williballenthin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-tz @williballenthin