-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change dynamic scope to call for atomic operations #952
Change dynamic scope to call for atomic operations #952
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1fdde58
to
4449de5
Compare
- or: | ||
- number: 0x40000000 = GENERIC_WRITE | ||
- number: 0x2 = FILE_WRITE_DATA | ||
- match: create or open file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's where things can get tricky: the scope of create or open file
is (fortunately) also call
, but in some other rules is a larger scope (like thread
), which is impossible to match.
so, i think this change is fine.
but we should be aware that in other scenarios, there's some tricky things we might have to fix.
4449de5
to
c9a586d
Compare
c9a586d
to
29dc617
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Thanks for all your suggestions, @jorik-utwente! I'm back this week to work on getting the improvements merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!!
To reduce false positives, we change the dynamic scope of a couple of operations to
call
.E.g., writing to the registry is always done in one Windows API call, so we change the scope from
thread
tocall
.Original discussion: #951