Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rendering of call and return addresses #1709

Merged
merged 4 commits into from
Aug 14, 2023
Merged

fix rendering of call and return addresses #1709

merged 4 commits into from
Aug 14, 2023

Conversation

williballenthin
Copy link
Collaborator

@williballenthin williballenthin commented Aug 11, 2023 •
edited
Loading

review and merge #1708 first.
closes #1702.

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@williballenthin williballenthin added bug Something isn't working gsoc Work related to Google Summer of Code project. dynamic related to dynamic analysis flavor cape related to CAPE sandbox report analysis labels Aug 11, 2023
@williballenthin williballenthin marked this pull request as ready for review August 11, 2023 09:07
@williballenthin
Copy link
Collaborator Author

verbose output:

image

This was referenced Aug 11, 2023
Closed
Merged
@williballenthin williballenthin changed the title fix #1702 fix rendering of call and return addresses Aug 11, 2023
@williballenthin williballenthin mentioned this pull request Aug 11, 2023
Merged
3 tasks
@yelhamer
Copy link
Collaborator

This looks good to me. Thanks @williballenthin !

@yelhamer yelhamer merged commit 84cddc7 into dynamic-feature-extraction Aug 14, 2023
8 of 16 checks passed
@yelhamer yelhamer deleted the fix/issue-1702 branch August 14, 2023 13:00
@yelhamer yelhamer mentioned this pull request Aug 14, 2023
Closed
9 tasks
@williballenthin williballenthin mentioned this pull request Aug 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yelhamer yelhamer yelhamer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cape related to CAPE sandbox report analysis dynamic related to dynamic analysis flavor gsoc Work related to Google Summer of Code project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williballenthin @yelhamer