Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossplane Configuration Packages #3

Closed
wants to merge 5 commits into from
Closed

Crossplane Configuration Packages #3

wants to merge 5 commits into from

Conversation

luebken
Copy link
Owner

@luebken luebken commented Sep 23, 2022

Signed-off-by: Matthias Luebken [email protected]

What does this PR do?

  • Adds two configuration package yamls to bundle the crossplane-aws-blueprints into a Crossplane configuration package both for provider-aws and provider-jet-aws
  • Include examples

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Signed-off-by: Matthias Luebken <[email protected]>
@luebken
Copy link
Owner Author

luebken commented Sep 23, 2022

There is a minor bug with kubectl crossplane build configuration:

cd compositions/aws-provider/
kubectl crossplane build configuration
kubectl crossplane: error: failed to build package: failed to parse package: {path:/Users/mdl/workspace/luebken/crossplane-aws-blueprints/compositions/aws-provider/eks/eks-managed-node-group-subnet-labels.yaml position:4096}: Object 'Kind' is missing in '# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
                           # SPDX-License-Identifier: MIT-0

                           '

The root-cause seems to be crossplane/crossplane-runtime#356

@luebken luebken changed the title first crossplane.yaml Crossplane Configuration Packages Sep 23, 2022
@luebken luebken closed this Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant