Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes comment separators at the beginning #49

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

luebken
Copy link
Contributor

@luebken luebken commented Sep 26, 2022

Signed-off-by: Matthias Luebken [email protected]

What does this PR do?

Removes the yaml doc separator at the beginning of the yamls. While this is valid yaml definition they are considered optional: (https://yaml.org/spec/1.0/#id2561718)

Motivation

We are running into an issue when building a configuration package. The current xpkg spec doesn't consider it a valid spec.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@luebken luebken marked this pull request as ready for review September 28, 2022 13:37
@vara-bonthu
Copy link
Contributor

The is @luebken! LGTM!

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nimakaviani nimakaviani merged commit 4b22c5c into awslabs:main Sep 28, 2022
@luebken luebken deleted the remove-doc-separator branch September 28, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants