Cherry-pick to earlgrey_1.0.0: [spi_host,flash] Add additional PMOD Flash tests for the BoB #25414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Renames the existing `spi_host_macronix_flash_test` target to the more specific `spi_host_macronix1Gb_flash_test`, and adds an additional `spi_host_macronix128Mb_flash_test` target which includes similar functionality, but that uses the correct chip select to talk to the 128 Megabit Macronix flash on the PMOD BoB. Signed-off-by: Alex Jones <[email protected]> (cherry picked from commit 93355af)
Signed-off-by: Alex Jones <[email protected]> (cherry picked from commit 8a2027e)
Signed-off-by: Alex Jones <[email protected]> (cherry picked from commit 1e37bd2)
There are two 256 Megabit Gigadevice SPI flashes available via PMOD on the Break-out Board. This extends the existing `spi_host_gigadevice256Mb_flash_test` (which only tested one of these) to now test both by using the correct chip select pins. Also makes a minor grammatical fix (`ManufactureID` -> `ManufacturerID`) in a couple of other PMOD Spi Flash tests. Signed-off-by: Alex Jones <[email protected]> (cherry picked from commit 385d8e0)
github-actions
bot
requested review from
timothytrippel
and removed request for
a team
engdoreis
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #25397 to branch
earlgrey_1.0.0.