-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 25065 from master to earlgrey_1.0.0 #25111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I flagged some issues with clkmgr and pwrmgr tests, and filed an issue for the clkmgr testpoints mentioned. Also, we need to resolve if redundant tests in pwrmgr are really worth running and taking CI time.
Obviously these issues need to be resolved in master, and if some change is made they should be cherry-picked.
Thanks @matutem for the review. |
@engdoreis I will be working on #25177 now and expect to have As for the other changes, my concern about pwrmgr is weak, since it may be useful to have simpler tests than the more comprehensive one and the tests are quick, so they are good to go. I am concerned about the chip_sw_flash_init testpoint: I think we need a more robust test in master before cherry picking it. So we need a new issue to address the shortcomings of chip_sw_flash_init in master before cherry picking it. Bottom line, all but the clkmgr and flash_ctrl testplan changes are okay. WDYT? @moidx? |
f29f616
to
299b5c2
Compare
@matutem I made the suggested changes. |
48d33b3
to
ffd7762
Compare
Signed-off-by: Douglas Reis <[email protected]> (cherry picked from commit b038317)
Signed-off-by: Douglas Reis <[email protected]> (cherry picked from commit 1dc2424)
Signed-off-by: Douglas Reis <[email protected]> (cherry picked from commit 51edb16)
Signed-off-by: Douglas Reis <[email protected]> (cherry picked from commit a61b9e3)
ffd7762
to
414a022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Douglas. LGTM
Update testplans and SiVal test suites
This Backport depends on #25091 to be merged first.