-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support full backup #166
feat: support full backup #166
Conversation
ab6fa5e
to
33878b2
Compare
cefced1
to
0f58353
Compare
0f58353
to
c9a780d
Compare
c9a780d
to
fe47e94
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
=======================================
Coverage 18.24% 18.24%
=======================================
Files 3 3
Lines 433 433
=======================================
Hits 79 79
Misses 347 347
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fe47e94
to
c788549
Compare
c788549
to
251a4c2
Compare
251a4c2
to
24e96f1
Compare
CI failed, will consult @FrankYang0529
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM.
Only few comments needing to address.
ref: longhorn/longhorn 7070 Signed-off-by: Jack Lin <[email protected]>
24e96f1
to
a14570f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref: longhorn/longhorn#7070
BackupCount
in BackupVolume, so we can calculate the interval to achieve periodically full backupNewlyUploadedDataSize
andReUploadedDataSize
to each Backup. So user can know the data transfer size for each Backup to trace the cost.Parameters
to the Backup Config.backup-mode: full
, it will pretend there is no last backup, and backup all the blocks of the current volume.