Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backup): support full backup #1061

Closed

Conversation

ChanYiLin
Copy link
Contributor

@ChanYiLin ChanYiLin commented Mar 19, 2024

ref: longhorn/longhorn#7070

  • add new parameter parameters to the createBackup() function
  • pass it from proxy -> task -> replica client

@ChanYiLin ChanYiLin self-assigned this Mar 19, 2024
@ChanYiLin ChanYiLin marked this pull request as draft March 19, 2024 09:44
@ChanYiLin ChanYiLin force-pushed the LH7070_support_full_backup branch 4 times, most recently from 06c6d57 to a65eab0 Compare March 22, 2024 02:59
Copy link

mergify bot commented Mar 29, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH7070_support_full_backup branch 2 times, most recently from 2a1d75a to 25b91ed Compare April 1, 2024 08:16
ref: longhorn/longhorn 7070

Signed-off-by: Jack Lin <[email protected]>
@ChanYiLin
Copy link
Contributor Author

Copy link

mergify bot commented Apr 24, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin
Copy link
Contributor Author

Since the grpc proto has been moved to types
I don't want to modify the PR and solve the conflicts
Will close this one and recreate the PR again
cc @derekbit @innobead

@ChanYiLin ChanYiLin closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant