Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(breaking) fix: turn on werror for all projects #63

Closed
wants to merge 7 commits into from

Conversation

jplaisted
Copy link
Contributor

SMV bumped to 0.3 due to breaking changes.

These changes were made in the werror branch and reviewed per commit, and that branch is now being rebased onto master.

#29

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link

@woodyzhou woodyzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SMV bumped to 0.3 due to breaking changes.

These changes were made in the werror branch and reviewed per commit, and that branch is now being rebased onto master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants