refactor: Added some raw types, checking for non-null resource before opening stream. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immmus
force-pushed
the
ebean_dao_refactor
branch
from
54a0f81
to
3617359
Compare
immmus
commented
Dec 10, 2020
| @@ -54,7 +54,7 @@ public ImmutableLocalDAO(@Nonnull Class<ASPECT_UNION> aspectUnionClass, | |||
| public ImmutableLocalDAO(@Nonnull Class<ASPECT_UNION> aspectUnionClass, | |||
| @Nonnull Map<URN, ? extends RecordTemplate> urnAspectMap, boolean ddlGenerate, @Nonnull Class<URN> urnClass) { | |||
There was a problem hiding this comment.
Also I have question about boolean ddlGenerate parameter. It's never use. It's okay or planned for future use?
There was a problem hiding this comment.
@keremsahin1 or @camelliazhang ? I'm not sure what this param is.
|
Nice! I don't know how I missed this sorry. Looks good to me, I think we can merge and let the unresolved question be answered afterwards. |
jplaisted
approved these changes
Jan 19, 2021
|
Also fwiw I have a big PR to fix all the rawtype issues in the code, but its breaking so I'm dragging my feet on it :) |
Oh okay, I'll wait these changes:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I research yours code and decided to make changes a small defects by my own view). If it is ok for you then I will continue do it:)
Main of this changes is checking for non-null resource before opening stream to warns NPE and reports that is problem.
And com.google.common.base.Charsets is deprecated since jdk 7, better to use standard java java.nio.charset.StandardCharsets. Thx:)
Checklist