-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builtin cost rework with fixes and entry point info #875
Conversation
This reverts commit 355c250.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
+ Coverage 82.99% 83.01% +0.01%
==========================================
Files 120 120
Lines 33866 34313 +447
==========================================
+ Hits 28108 28485 +377
- Misses 5758 5828 +70 ☔ View full report in Codecov by Sentry. |
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.296 ± 0.093 | 11.163 | 11.438 | 8.33 ± 0.07 |
cairo-native (embedded AOT) |
3.502 ± 0.025 | 3.477 | 3.544 | 2.58 ± 0.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.310 ± 0.031 | 3.267 | 3.356 | 2.44 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
1.356 ± 0.002 | 1.354 | 1.360 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.683 ± 0.040 | 11.605 | 11.734 | 143.71 ± 0.60 |
cairo-native (embedded AOT) |
3.041 ± 0.028 | 3.013 | 3.102 | 37.40 ± 0.35 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.854 ± 0.022 | 2.822 | 2.896 | 35.11 ± 0.29 |
cairo-native (standalone AOT with -march=native) |
0.081 ± 0.000 | 0.081 | 0.082 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.422 ± 0.036 | 4.358 | 4.464 | 18.15 ± 0.15 |
cairo-native (embedded AOT) |
3.219 ± 0.029 | 3.174 | 3.273 | 13.21 ± 0.12 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.105 ± 0.022 | 3.056 | 3.133 | 12.74 ± 0.09 |
cairo-native (standalone AOT with -march=native) |
0.244 ± 0.001 | 0.243 | 0.245 | 1.00 |
Benchmark results Main vs HEAD.
|
✅ Code is now correctly formatted. |
* store entry point info, optimize abi storage * use felt * update hash
…nto revert_revert
This reverts commit 40f1acc.
There is currently a bug when using replay with this branch, i'm looking into it to reproduce with replay:
|
Fixed, was a problem with using a stack value on recursive contract calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @edg-l !
This reverts commit 355c250.
We should test this change with a block range we know works with current main, to assert it adds no regressions.
Also adds entry point info, fixes #885
Checklist