-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entry point info to AotContractExecutor #889
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.589 ± 0.224 | 10.366 | 10.998 | 23.11 ± 0.49 |
cairo-native (embedded AOT) |
3.151 ± 0.025 | 3.128 | 3.210 | 6.88 ± 0.06 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.168 ± 0.022 | 3.123 | 3.191 | 6.91 ± 0.05 |
cairo-native (standalone AOT) |
0.651 ± 0.001 | 0.648 | 0.652 | 1.42 ± 0.00 |
cairo-native (standalone AOT with -march=native) |
0.458 ± 0.001 | 0.457 | 0.460 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.713 ± 0.250 | 10.365 | 10.936 | 1337.53 ± 32.83 |
cairo-native (embedded AOT) |
2.663 ± 0.017 | 2.643 | 2.689 | 332.44 ± 3.25 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.717 ± 0.017 | 2.684 | 2.737 | 339.27 ± 3.28 |
cairo-native (standalone AOT) |
0.008 ± 0.000 | 0.008 | 0.008 | 1.00 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.248 ± 0.035 | 4.195 | 4.309 | 59.52 ± 0.55 |
cairo-native (embedded AOT) |
2.846 ± 0.024 | 2.812 | 2.889 | 39.87 ± 0.38 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.988 ± 0.017 | 2.953 | 3.014 | 41.86 ± 0.29 |
cairo-native (standalone AOT) |
0.115 ± 0.001 | 0.114 | 0.121 | 1.61 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
0.071 ± 0.000 | 0.071 | 0.073 | 1.00 |
Benchmark results Main vs HEAD.
|
edg-l
requested review from
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
October 28, 2024 10:15
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## revert_revert #889 +/- ##
=================================================
+ Coverage 82.83% 82.86% +0.03%
=================================================
Files 120 120
Lines 35236 35307 +71
=================================================
+ Hits 29187 29258 +71
Misses 6049 6049 ☔ View full report in Codecov by Sentry. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
* Revert "Revert builtin cost rework (#874)" This reverts commit 355c250. * x * fix gas * add paralel test * Add entry point info to AotContractExecutor (#889) * store entry point info, optimize abi storage * use felt * update hash * upd replay * try with thread local * try to fix with thread local in runtime2 * fix * upd ref ci * upd replay * fix macos * try to fix macos * try to fix bench * fix * try to fix bench ci * save space * upd rev * try to fix broken pipe * try to fix bench on ci * remove all features * add cache key * update replay rev * fix cargo.lock * Revert "update replay rev" This reverts commit 40f1acc. * fix cargo.lock * works with leaks * fix * upd replay * fix bench * Reorder deps --------- Co-authored-by: Pedro Fontana <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: Julián González Calderón <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Revert "Revert builtin cost rework (#874)" This reverts commit 355c250. * x * fix gas * add paralel test * Add entry point info to AotContractExecutor (#889) * store entry point info, optimize abi storage * use felt * update hash * upd replay * try with thread local * try to fix with thread local in runtime2 * fix * upd ref ci * upd replay * fix macos * try to fix macos * try to fix bench * fix * try to fix bench ci * save space * upd rev * try to fix broken pipe * try to fix bench on ci * remove all features * add cache key * update replay rev * fix cargo.lock * Revert "update replay rev" This reverts commit 40f1acc. * fix cargo.lock * works with leaks * fix * upd replay * fix bench * Reorder deps * start porting gas to u64 * u64 on syscalls * fix * Fix benches. * clippy * fix gas refund * fmt * fix * fix get gas * update resource bounds * upd ci * upd replay * fix ci * try * fix align * fix bench pr * better fix for u256 * upd replay * upd replay * fix * remove dbg! * upd replay * fix * Revert conversion of `ResourceBounds` field type. * Update sequencer revision (for CI runs). * Update replay dependency. * read invoke data end pad * upd ci --------- Co-authored-by: Pedro Fontana <[email protected]> Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: Julián González Calderón <[email protected]> Co-authored-by: Esteve Soler Arderiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows us to filter out methods that are not contract entry points, making the JSON file significantly smaller.
Depends on #875
Fixes #885
Checklist