-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(history): update history file format to handler multiple task runner like pnpm, yarn, e.t.c. #315 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyu08
force-pushed
the
refactor-history-for-315
branch
from
November 13, 2024 15:28
5a87065
to
f73d90a
Compare
kyu08
changed the title
refactor(history): #315
update(history): update history file format to handler multiple task runner like pnpm, yarn, e.t.c. #315
Nov 17, 2024
kyu08
force-pushed
the
refactor-history-for-315
branch
from
November 23, 2024 16:11
e48477e
to
6ceb0bd
Compare
kyu08
force-pushed
the
refactor-history-for-315
branch
from
November 23, 2024 16:24
51d3857
to
3e64452
Compare
kyu08
force-pushed
the
refactor-history-for-315
branch
from
November 24, 2024 03:46
2435fa2
to
bea7197
Compare
kyu08
force-pushed
the
refactor-history-for-315
branch
from
November 24, 2024 03:57
deab2b8
to
bc61ca9
Compare
kyu08
commented
Nov 24, 2024
} | ||
} | ||
|
||
// TODO: should return Result not Option(returns when it fails to get the home dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wont fix in this PR
kyu08
force-pushed
the
refactor-history-for-315
branch
from
November 24, 2024 04:12
4e883cf
to
d9a71bd
Compare
… descending in the history file.
kyu08
force-pushed
the
refactor-history-for-315
branch
from
November 24, 2024 04:25
36b8c47
to
a5acdc6
Compare
kyu08
force-pushed
the
refactor-history-for-315
branch
from
November 24, 2024 06:28
271baad
to
8917117
Compare
kyu08
force-pushed
the
refactor-history-for-315
branch
from
November 24, 2024 06:28
8917117
to
b19cddc
Compare
kyu08
force-pushed
the
refactor-history-for-315
branch
from
November 24, 2024 06:43
07e043f
to
c655f91
Compare
kyu08
force-pushed
the
refactor-history-for-315
branch
from
November 24, 2024 06:56
8d30642
to
424bfa8
Compare
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor for #315.
Resolves #323.
TODO(specification)
--repeat
fzf-make/src/usecase/repeat.rs
Line 28 in 788bb4b
Just run latest command. New history file format enables it.
TODO(implementation)
When the history file type is the old format(without runner information), rewrite it using the new format immediately.When the history file type is the old format(without runner information), rewrite it using the new format immediately. #326target
tocommand
.New history file format
A format not adopted
Old format
TODO(review)
model/
tui/
model/
tui/
model/
tui/