-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make supporting command runners other than make
possible like npm, pnpm, yarn and just, e.t.c.
#315
Closed
2 tasks done
Comments
AsIspub enum AppState<'a> {
SelectTarget(SelectTargetState<'a>),
ExecuteTarget(Option<String>),
ShouldQuit,
} ToBepub enum AppState<'a> {
SelectTarget(SelectTargetState<'a>),
ExecuteTarget(Option<Command>), // Change to Command
ShouldQuit,
}
pub trait Command {
fn print(&self); // Print command to run like `make run` before execute it.
fn execute(&self);
}
|
2 tasks
kyu08
added a commit
that referenced
this issue
Nov 11, 2024
… able to add other command runner like pnpm, yarn, etc. #315 (#321) * define Runner trait * wip: Implement Makefile runner * rename: model::Makefile -> model::Make * add: implement Selector for Make * fix: use Selector trait from caller side * rename: makefile -> runners * fix: append_history * fix: narrow_down_targets * fix: app.rs * fix: history x UI周辺を追従 * add: command::Command * fix: comment * wip: trait object * wip: enum * Command * fix: comment * delete: pnpm * comment out history related test code * treat with temporal dead code * delete dead code * fix: how to print command to run * chore: refactor
18 tasks
kyu08
added a commit
that referenced
this issue
Nov 24, 2024
…runner like pnpm, yarn, e.t.c. #315 (#324) * empty commit * wip * wip * wip * wip * wip * wip * wip * read history * write history * append_history * delete unnecessary code * specify_makefile_name: receive current_dir as an argument instead of using `env::current_dir` * delete unnecessary code * fix comment * use command.runner_type.to_runner instead of s.runners[0] * SelectTargetState.histories: Add comment * add pretty_assertions * rename * histories.append * history.append * comment in tests temporary disabled * rename: target -> command * Add a comment tells that the the commands are sorted by executed time descending in the history file. * format import statements * remove unnecessary comment * make `content_to_include_file_paths` private * delete unnecessary path specification * make.rs: rename create_makefile to new, new to new_internal * change format to display command: (runner_type) name -> [runner_type] name] * model/histories.rs: fix comment * make some methods private * rename var name * rename: store_history -> create_or_update_history_file * delete unnecessary code * reoder import block
kyu08
changed the title
Support some JavaScript package manager like npm, pnpm, yarn and bun
Make supporting some JavaScript package manager possible like npm, pnpm, yarn and bun
Nov 24, 2024
kyu08
changed the title
Make supporting some JavaScript package manager possible like npm, pnpm, yarn and bun
Make supporting command runners other than Nov 24, 2024
make
possible like npm, pnpm, yarn and just, e.t.c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requirements
This executes "npm run test". Are you sure?
.TODO(Before this enhancement)
make
,npm
,pnpm
etc, and refine the architecture. See: Make supporting command runners other thanmake
possible like npm, pnpm, yarn and just, e.t.c. #315 (comment).The text was updated successfully, but these errors were encountered: