refactor(makefile): refactor Makefile struct to Runner enum to be able to add other command runner like pnpm, yarn, etc. #315
#321
+889
−500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyu08
force-pushed
the
refactor-for-315
branch
from
a50d290
to
5e0e17c
Compare
kyu08
force-pushed
the
refactor-for-315
branch
2 times, most recently
from
fdddc36
to
2ca30a4
Compare
kyu08
force-pushed
the
refactor-for-315
branch
from
2ca30a4
to
ca7c7d3
Compare
kyu08
force-pushed
the
refactor-for-315
branch
from
ef59a72
to
52e001d
Compare
kyu08
force-pushed
the
refactor-for-315
branch
from
4eca8e1
to
09fc0f0
Compare
kyu08
force-pushed
the
refactor-for-315
branch
2 times, most recently
from
745849c
to
2f01742
Compare
kyu08
force-pushed
the
refactor-for-315
branch
from
2f01742
to
f60e0d5
Compare
kyu08
force-pushed
the
refactor-for-315
branch
from
525361c
to
30c0cc2
Compare
kyu08
force-pushed
the
refactor-for-315
branch
from
30c0cc2
to
bee9d88
Compare
kyu08
changed the title
Runner trait for Makefile struct #315Makefile struct to Runner enum to be able to add other command runner like pnpm, yarn, etc. #315
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor for #315.
What this PR does
Makefilestruct toRunnerenum to be able to add other command runner like pnpm, yarn... .What this PR does not do
History functionality compatible with multiple runners will be implemented in another PR.
TODO