Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ospf container #820

Merged
merged 19 commits into from
Nov 25, 2024
Merged

Ospf container #820

merged 19 commits into from
Nov 25, 2024

Commits on Nov 25, 2024

  1. x86_64: Enable kprobes and ftrace in kernel 

    This avoids full recompiles every time we want to use things like ply.
    @wkz @mattiaswal
    wkz authored and mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a3af3f9 View commit details
    Browse the repository at this point in the history

  2. confd: Abort if callback tracking ever fails 

    During debugging of a reconfiguration issue, one hypothesis was that
the tracking of callbacks used to determine when a transaction has
completed (as sysrepo has no hooks for this) was out of sync, causing
us to call `initctl reload` prematurely. This was not the case, but if
it ever occurs in the future, make sure that it is a fatal error that
won't go unnoticed.
    @wkz @mattiaswal
    wkz authored and mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d99b6fd View commit details
    Browse the repository at this point in the history

  3. buildroot: Bump to latest 2024.02.x-kkit for FRR 9.1.2 

    During development of the upcoming ospf_container test, an issue was
discovered where zebra's view of the system drifted from the kernel's
ditto. Specifically: when transitioning from test-config to one with
many virtual interfaces (VLANs VETH pairs etc.), zebra would not
process events for all interfaces, which meant OSPF would not pick
them up.

Our experience matches very well with a bug reported upstream in:

FRRouting/frr#13630

> If we delete kernel interface and create it and set its ip in a
> short time, in rare cases, interface ip will be lost in zebra which
> can be confirmed by vtysh show interface brirf command. This will
> lead to abnormal behavior of other protocol daemons, for example,
> bgpd does not announce the route corresponding to interface ip even
> it was specified by network command.

The issue was marked as fixed by PR 13396, which was merged in the 9.0
cycle:

FRRouting/frr#13396

Therefore, upgrade FRR to the latest patch release from that major.
    @wkz @mattiaswal
    wkz authored and mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    de47cae View commit details
    Browse the repository at this point in the history

  4. yanger: Tolerate missing DR/BDR IDs in OSPF neighbor info 

    With the FRR upgrade to 9.1.2, OSPF sometimes reports neighbors
without reporting the routerDesignatedId and routerDesignatedBackupId
attributes. Ensure that these attributes are available before trying
to copy them to the output.
    @wkz @mattiaswal
    wkz authored and mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fabb28b View commit details
    Browse the repository at this point in the history

  5. infamy: Update template topologies to use the correct font

    @mattiaswal
    mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5264a1c View commit details
    Browse the repository at this point in the history

  6. test-spec: Add support for images in description

    @mattiaswal
    mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c7db71d View commit details
    Browse the repository at this point in the history

  7. infamy: Expose the new IsolatedMacVlans for tests

    @mattiaswal
    mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    82fd4bd View commit details
    Browse the repository at this point in the history

  8. Add new test: ospf_container 

    Aims to test a complex setup with multiple containers, OSPF and NAT
    @mattiaswal
    mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    bbc9a55 View commit details
    Browse the repository at this point in the history

  9. README: minor, grammar. 

    Signed-off-by: Joachim Wiberg <[email protected]>
    @troglobit @mattiaswal
    troglobit authored and mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    14dea0c View commit details
    Browse the repository at this point in the history

  10. test/case: add description for ospf container use-case 

    Signed-off-by: Joachim Wiberg <[email protected]>
    @troglobit @mattiaswal
    troglobit authored and mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c0ee090 View commit details
    Browse the repository at this point in the history

  11. test: use_case: Update test with HTTP container and ABR 

    Add ABR configuration and a HTTP Container
    @mattiaswal
    mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    7a642f9 View commit details
    Browse the repository at this point in the history

  12. test/case: update use-case internal network description 

    Signed-off-by: Joachim Wiberg <[email protected]>
    @troglobit @mattiaswal
    troglobit authored and mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    6d6a788 View commit details
    Browse the repository at this point in the history

  13. test/case: minor, grammar and formatting 

    Signed-off-by: Joachim Wiberg <[email protected]>
    @troglobit @mattiaswal
    troglobit authored and mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f381977 View commit details
    Browse the repository at this point in the history

  14. ospf_containers: Convert to use put_config_dicts

    @mattiaswal
    mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    81f80bd View commit details
    Browse the repository at this point in the history

  15. test: case: ospf_container: Update test 

    Add "VLAN switches" between each Router, to only pass the tagged traffic
between the routers.

Add test specification and add to test suite
    @mattiaswal
    mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    1cfbf9b View commit details
    Browse the repository at this point in the history

  16. test: add drawio original and update images in use-case test 

    Signed-off-by: Joachim Wiberg <[email protected]>
    @troglobit @mattiaswal
    troglobit authored and mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    77df9a3 View commit details
    Browse the repository at this point in the history

  17. test: factor out file server from upgrade test 

    Signed-off-by: Joachim Wiberg <[email protected]>
    @troglobit @mattiaswal
    troglobit authored and mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    866b9de View commit details
    Browse the repository at this point in the history

  18. infamy: Stability fix for getting OSPF status 

    Always return {} if fail to get OSPF status, it may not have started
yet.
    @mattiaswal
    mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    66ae023 View commit details
    Browse the repository at this point in the history

  19. test-spec: Remove autogenerated file 

    Add it to gitignore to not be added again.
    @mattiaswal
    mattiaswal committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    de50179 View commit details
    Browse the repository at this point in the history