Ospf container #820
Merged
Ospf container #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaswal
force-pushed
the
ospf-container
branch
6 times, most recently
from
1955b15
to
7d58db2
Compare
wkz
force-pushed
the
ospf-container
branch
2 times, most recently
from
26ab349
to
a555112
Compare
troglobit
approved these changes
Nov 25, 2024
This avoids full recompiles every time we want to use things like ply.
During debugging of a reconfiguration issue, one hypothesis was that the tracking of callbacks used to determine when a transaction has completed (as sysrepo has no hooks for this) was out of sync, causing us to call `initctl reload` prematurely. This was not the case, but if it ever occurs in the future, make sure that it is a fatal error that won't go unnoticed.
During development of the upcoming ospf_container test, an issue was discovered where zebra's view of the system drifted from the kernel's ditto. Specifically: when transitioning from test-config to one with many virtual interfaces (VLANs VETH pairs etc.), zebra would not process events for all interfaces, which meant OSPF would not pick them up. Our experience matches very well with a bug reported upstream in: FRRouting/frr#13630 > If we delete kernel interface and create it and set its ip in a > short time, in rare cases, interface ip will be lost in zebra which > can be confirmed by vtysh show interface brirf command. This will > lead to abnormal behavior of other protocol daemons, for example, > bgpd does not announce the route corresponding to interface ip even > it was specified by network command. The issue was marked as fixed by PR 13396, which was merged in the 9.0 cycle: FRRouting/frr#13396 Therefore, upgrade FRR to the latest patch release from that major.
With the FRR upgrade to 9.1.2, OSPF sometimes reports neighbors without reporting the routerDesignatedId and routerDesignatedBackupId attributes. Ensure that these attributes are available before trying to copy them to the output.
mattiaswal
force-pushed
the
ospf-container
branch
from
a555112
to
e057a29
Compare
Aims to test a complex setup with multiple containers, OSPF and NAT
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Add ABR configuration and a HTTP Container
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Add "VLAN switches" between each Router, to only pass the tagged traffic between the routers. Add test specification and add to test suite
Signed-off-by: Joachim Wiberg <[email protected]>
Signed-off-by: Joachim Wiberg <[email protected]>
Always return {} if fail to get OSPF status, it may not have started
yet.
mattiaswal
force-pushed
the
ospf-container
branch
from
e057a29
to
a567ae9
Compare
Add it to gitignore to not be added again.
mattiaswal
force-pushed
the
ospf-container
branch
from
a567ae9
to
de50179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #652 (but larger 0.0.0.1 case is the same), fixes #776 and fixes #743
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: