Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't persist letter filter when querying #6264

Closed
wants to merge 3 commits into from

Conversation

viown
Copy link
Member

@viown viown commented Oct 28, 2024

Currently, the letter filter will only be persisted in some media types if you first select a letter, then use 'sort' or 'filter' (which calls save). In other media types like shows it's saved when items are loaded.

Changes
To stay consistent, prevent the letter filter from being saved anywhere.

Issues
Fixes #6263

@viown viown requested a review from a team as a code owner October 28, 2024 11:44
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Oct 28, 2024

Cloudflare Pages deployment

Latest commit 18ea570
Status ✅ Deployed!
Preview URL https://543c3be2.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@viown
Copy link
Member Author

viown commented Oct 28, 2024

I just noticed that If someone has an active letter filter and they used this, they wouldn't be able to get rid of the filter unless they cleared cache. To circumvent this, I'll remove these fields in loadQuerySettings as well.

@thornbill thornbill added bug Something isn't working regression We broke something labels Oct 28, 2024
@thornbill thornbill added this to the v10.10.1 milestone Oct 28, 2024
@thornbill thornbill added the stable backport Backport into the next stable release label Oct 28, 2024
@viown
Copy link
Member Author

viown commented Oct 28, 2024

Hmm, wondering if it's better to 'whitelist' certain query fields instead.

@thornbill
Copy link
Member

That was the previous approach... 7074d41

Copy link

sonarcloud bot commented Oct 29, 2024

@aaemon
Copy link
Contributor

aaemon commented Oct 29, 2024

btnShuffle, btnSelectView, btnSort, btnFilter, and alphaPicker are all persistent across different devices. So, trying to use a filter on one device messes up all other devices connected to the same account.

@viown
Copy link
Member Author

viown commented Oct 29, 2024

btnShuffle, btnSelectView, btnSort, btnFilter, and alphaPicker are all persistent across different devices. So, trying to use a filter on one device messes up all other devices connected to the same account.

The settings are indeed server-side. To match previous behavior, we can make sorting work across devices but keep filtering local to each device. It's better that we do this in another PR.

@viown viown closed this Oct 30, 2024
@viown viown deleted the dont-persist-letter branch November 1, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression We broke something stable backport Backport into the next stable release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants