-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't persist letter filter when querying #6264
Conversation
Cloudflare Pages deployment
|
I just noticed that If someone has an active letter filter and they used this, they wouldn't be able to get rid of the filter unless they cleared cache. To circumvent this, I'll remove these fields in |
Hmm, wondering if it's better to 'whitelist' certain query fields instead. |
That was the previous approach... 7074d41 |
Quality Gate passedIssues Measures |
btnShuffle, btnSelectView, btnSort, btnFilter, and alphaPicker are all persistent across different devices. So, trying to use a filter on one device messes up all other devices connected to the same account. |
The settings are indeed server-side. To match previous behavior, we can make sorting work across devices but keep filtering local to each device. It's better that we do this in another PR. |
Currently, the letter filter will only be persisted in some media types if you first select a letter, then use 'sort' or 'filter' (which calls save). In other media types like shows it's saved when items are loaded.
Changes
To stay consistent, prevent the letter filter from being saved anywhere.
Issues
Fixes #6263