Make filtering local to each device #6274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
thornbill
reviewed
Oct 30, 2024
|
thornbill
added
bug
thornbill
approved these changes
Nov 1, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
Nov 3, 2024
Make filtering local to each device Original-merge: ad8868a Merged-by: thornbill <[email protected]> Backported-by: Joshua M. Boniface <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #6264
This makes 'filtering' local to each device while keeping sorting settings stored on the server. Additionally, this fixes the issue with storing query options which don't make sense to save (current page, letter filter, etc)
Due to a key change, this will reset any saved filtering settings but will keep sorting intact.
Changes
Issues
Fixes #6263
Fixes #6268
#6264 (comment)