Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(enclave): remove build.rs and copy data files #259

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Oct 17, 2024

We hit a build issue in #258 when depending on quartz-enclave-core v0.1.0 ->

cycles-quartz/examples/transfers/enclave$ cargo build
   Compiling quartz-proto v0.1.0
   Compiling quartz-contract-core v0.1.0
   Compiling quartz-tm-stateless-verifier v0.1.0
   Compiling quartz-enclave-core v0.1.0
   Compiling quartz-tm-prover v0.1.0
   Compiling cw-client v0.1.0
error: failed to run custom build command for `quartz-enclave-core v0.1.0`

Caused by:
  process didn't exit successfully: `/home/vboxuser/Downloads/cycles-quartz/examples/transfers/target/debug/build/quartz-enclave-core-e346fbb3e8b55026/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at /home/vboxuser/.cargo/registry/src/index.crates.io-6f17d22bba15001f/quartz-enclave-core-0.1.0/build.rs:22:33:
  Failed to copy "/home/vboxuser/.cargo/registry/src/index.crates.io-6f17d22bba15001f/quartz-enclave-core-0.1.0/../../../crates/contracts/tee-ra/data/qe_identity.json"
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

This is basically caused due to a bug in the build.rs script's handling of paths. This PR removes the build.rs script entirely and jsut copies the DCAP certs/files into the crate. The PR also bumps the version of the quartz-enclave-core and quartz-common crates to v0.1.1.

Copy link
Contributor

@dusterbloom dusterbloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes viewed and they all seems just fine

@hu55a1n1 hu55a1n1 merged commit 811771f into main Oct 17, 2024
6 of 7 checks passed
@hu55a1n1 hu55a1n1 deleted the hu55a1n1/fix-enclave-core-build branch October 17, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants