Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed directional convention of energy flows in thermal_simulation.py #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed directional convention of energy flows in thermal_simulation.py #1

wants to merge 1 commit into from

Commits on Oct 16, 2024

  1. Fixed directional convention of energy flows in thermal_simulation.py 

    The calculation of the mass flow out of nodes was based on calculating the mass flow into nodes and flipping the sign. Now the mass flow out of nodes is calculated directly. Given conservation of mass, this should not change anything. However, there are small numerical imprecisions. This change make the calculation more accurate.
    @lkmo-stack
    lkmo-stack authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    24295f8 View commit details
    Browse the repository at this point in the history