Fixed directional convention of energy flows in thermal_simulation.py #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation of the mass flow out of nodes was based on calculating the mass flow into nodes and flipping the sign. Now the mass flow out of nodes is calculated directly. Given conservation of mass, this should not change anything. However, there are small numerical imprecisions. This change make the calculation more accurate.
|
Hi @lkmo-stack, thank you very much for pointing this out and for the pull request. I’ll run some tests to see how the Jacobian behaves and plan to merge it in the next update along with some other fixes. Do you have any insights on cases where the current convention leads to numerical imprecisions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of the mass flow out of nodes was based on calculating the mass flow into nodes and flipping the sign. Now the mass flow out of nodes is calculated directly. Given conservation of mass, this should not change anything. However, there are small numerical imprecisions. This change make the calculation more accurate.