Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teams view as tiles #379

Open
1 task
zhamanakov opened this issue Jan 17, 2018 · 16 comments · Fixed by #432
Open
1 task

Teams view as tiles #379

zhamanakov opened this issue Jan 17, 2018 · 16 comments · Fixed by #432

Comments

@zhamanakov
Copy link

zhamanakov commented Jan 17, 2018

#380 depends on this for tile component
#374 depends on this for tile component and team logic

New Layout for "Teams" Page:

Header and footer are out of scope.
If the team has a team-picture, then tile has this picture. If not, then we use 1 of 2 default pictures (they can be easily found by link in Flexibus channel)

In wide-screens every tile has a 25% of width with paddings/margins.
If width for content is <=800px, then it's only 2 blocks in a row. (this is not shown in pictures)
In it is <=400 px, then only 1 block in a row. (IT IS ONLY EXAMPLE - the most important thing, that it looks good on every screen 300 to 1600px).
Don't forget that content has max-width:1200px!

  • create a reusable component for the tiles that can be used in Events view as tiles #380.

  • whole tile should be clickable

  • no priority for teams

  • 'Deine Teams' only shows teams that user is a member of

  • 'Deine Teams' is subset of 'Alle Teams' (not disjunct)

  • 'Deine Teams' block is not shown when there is no data

teams1.png

teams2.png

@JakobEdding
Copy link
Member

Estimation: L

emanuel-metzenthin pushed a commit that referenced this issue Jan 18, 2018
@ghost ghost added in progress and removed ready labels Jan 18, 2018
emanuel-metzenthin pushed a commit that referenced this issue Jan 18, 2018
deeps96 pushed a commit that referenced this issue Jan 18, 2018
@JakobEdding
Copy link
Member

JakobEdding commented Jan 19, 2018

Some work for the tiles might've already been done in #294 that we could build on, please check with the respective team @emanuel-metzenthin @deeps96.

@emanuel-metzenthin
Copy link

@jak-ing Isn't #294 a duplicate of #380?

@MariusDanner
Copy link
Contributor

@emanuel-metzenthin I thought so too, but they aren't doing design i think

Yes just put the options for picture upload and the default image. The rest should be handled by the team of @zhamanakov :)

@JakobEdding
Copy link
Member

Exactly. I just wanted to let you know because it came up in the scrum master meeting today.

@zhamanakov
Copy link
Author

Important: "Players: X/Y" from mockup is now out.
Every Team-tile has a picture, name and kind of sports.

And please think, how we shorten list of kind of sports in tile in the case, if this list is tooo long.
May be only 1 (or 2) strings and then "..."

@emanuel-metzenthin
Copy link

Okay.

emanuel-metzenthin pushed a commit that referenced this issue Jan 31, 2018
emanuel-metzenthin pushed a commit that referenced this issue Jan 31, 2018
emanuel-metzenthin pushed a commit that referenced this issue Jan 31, 2018
emanuel-metzenthin pushed a commit that referenced this issue Jan 31, 2018
@ghost ghost removed the review label Jan 31, 2018
@JakobEdding JakobEdding reopened this Jan 31, 2018
emanuel-metzenthin pushed a commit that referenced this issue Feb 1, 2018
emanuel-metzenthin pushed a commit that referenced this issue Feb 1, 2018
@ghost ghost removed the review label Feb 1, 2018
emanuel-metzenthin pushed a commit that referenced this issue Feb 1, 2018
@JakobEdding JakobEdding reopened this Feb 1, 2018
@zhamanakov zhamanakov changed the title Teams view as tiles Teams viespow as tiles Feb 4, 2018
@zhamanakov
Copy link
Author

zhamanakov commented Feb 4, 2018

why has one team different pictures?

Screen Shot 2018-02-04 at 13.00.56.png

Response 1

They have different pictures as you have requested i:

If the team has a team-picture, then tile has this picture. If not, then we use 1 of 2 default pictures (they can be easily found by link in Flexibus channel)

You might have not set a team picture. Thats why it gets assigned the volleyball picture if you are a member of this team and the soccer image if it listed in "all teams".

Zhamanakov:

@emanuel-metzenthin @MariusDanner
can we make that one team has always the same default pic?

@JakobEdding JakobEdding changed the title Teams viespow as tiles Teams view as tiles Feb 4, 2018
@deeps96 deeps96 removed their assignment Feb 4, 2018
@zhamanakov
Copy link
Author

zhamanakov commented Feb 5, 2018

[Done] Max-width of content on page should be 1200px:
Screen Shot 2018-02-05 at 22.14.26.png

Leonardo

I will take care about that in #381.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants