Flexibus/#379/teams page design #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
emanuel-metzenthin
requested review from
Blubl and
deeps96
and removed request for
deeps96
deeps96
requested changes
Jan 31, 2018
There was a problem hiding this comment.
Remove this selection:
There is still some intend, which was explicitly not requested by PO. @zhamanakov Is this ok?
Intendation is slightly bigger on square images.
Overall code looks okay to me.
| @@ -169,6 +169,7 @@ img.avatar { | |||
|
|
|||
| .container, .container-fluid{ | |||
| max-width: 1200px; | |||
| width: 100% !important; | |||
There was a problem hiding this comment.
Why is this change assigned to this ticket? - I think it belongs to #183.
There was a problem hiding this comment.
That was part of Dimas requested changes for the event tiles as bootstrap somehow always set the container width to 70%.
There was a problem hiding this comment.
FYI: The container stuff is generally wanted and comes from Materialize.
added 7 commits
February 1, 2018 09:31
…hpi-swt2/sport-portal into flexibus/#379/teams-page-design
deeps96
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated requested changes, closes #379.