Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events view as tiles #380

Closed
zhamanakov opened this issue Jan 17, 2018 · 14 comments
Closed

Events view as tiles #380

zhamanakov opened this issue Jan 17, 2018 · 14 comments
Assignees
@jcremerius @MariusDanner
Labels
epic design Team Flexibus

Comments

@zhamanakov
Copy link

zhamanakov commented Jan 17, 2018 •
edited by JakobEdding
Loading

This depends on #379 for tile component
#374 depends on this for event logic

New Layout for "Events" Page:

Header and footer are out of scope.
If the event has a event-picture, then tile has this picture. If not, then we use 1 of 2 default pictures (they can be easily found in Flexibus channel)

In wide-screens every tile has a 25% of width with paddings/margins.
If width for content is <=800px, then it's only 2 blocks in a row.
In it is <=400 px, then only 1 block in a row. (IT IS ONLY EXAMPLE - the most important thing, that it looks good on every screen 300 to 1600px).
Don't forget that content has max-width:1200px!

  • 'Deine Events' = I'm a member, my team is a member, I created the event
  • 'Deine Events' is not shown when there is no data

event1.png

event2.png
@zhamanakov zhamanakov mentioned this issue Jan 17, 2018
Open
1 task
@JakobEdding
Copy link
Member

Estimation: L

@zhamanakov zhamanakov mentioned this issue Jan 18, 2018
Closed
3 tasks
@jcremerius
Copy link
Contributor

@zhamanakov Should the user be able to click on the event to reach the event specific site? If yes where should the user click to go to the even?
Thanks!

@ghost ghost added in progress and removed ready labels Jan 18, 2018
@JakobEdding
Copy link
Member

Yesterday in the sprint planning we agreed that the whole tile should be clickable.

MariusDanner added a commit that referenced this issue Jan 18, 2018
@MariusDanner
Add failing test for finding all events for one user functionality. #380
4c54617
MariusDanner added a commit that referenced this issue Jan 18, 2018
@MariusDanner
Implement find all events for one user functionality. #380
33ca63f
MariusDanner added a commit that referenced this issue Jan 18, 2018
@MariusDanner
Merge branch 'flexibus/#379/teams-page-design' into flexibus/#380/eve…
c9b1a45 
…nts-view-as-tiles
MariusDanner added a commit that referenced this issue Jan 18, 2018
@MariusDanner
Add tile design. #380
6e795f3
jcremerius added a commit that referenced this issue Jan 18, 2018
@jcremerius
Show the create new event button correctly and adds design for the mo…
e4e5b41 
…bile version, as the complete picture gets displayed now

    #380
jcremerius added a commit that referenced this issue Jan 19, 2018
@jcremerius
Add the startdate and deadline to the event page
a926d5c 
    #380
jcremerius added a commit that referenced this issue Jan 19, 2018
@jcremerius
Add an event specific tile template
7881f86 
            #380
jcremerius added a commit that referenced this issue Jan 19, 2018
@jcremerius
Add bold headlines and reduces the padding of the event elements
9e85c7c 
    #380
jcremerius added a commit that referenced this issue Jan 19, 2018
@jcremerius
Modify the mobile-btn css in event so the button text is displayed ce…
8ee7924 
…ntral

    #380
MariusDanner added a commit that referenced this issue Jan 19, 2018
@MariusDanner
Apply DRY to the design. #380
d10bf72
MariusDanner added a commit that referenced this issue Jan 19, 2018
@MariusDanner
Merge branch 'flexibus/#380/events-view-as-tiles' of github.com:hpi-s…
6714c8b 
…wt2/sport-portal into flexibus/#380/events-view-as-tiles
@JakobEdding
Copy link
Member

It seems to me like right now there is no image displayed in the frontend for each event. However, it seems the logic for that was already implemented in #294 @nikriek?! Just to make sure we don't do work twice...

@zhamanakov
Copy link
Author

@jcremerius yes and all the tile is a link (pic + name + all params)

MariusDanner added a commit that referenced this issue Jan 19, 2018
@MariusDanner
Change event titel staling. #380
60377ac
@nikriek
Copy link
Contributor

nikriek commented Jan 19, 2018 via email

jcremerius added a commit that referenced this issue Jan 19, 2018
@jcremerius
Resolve the line break issue when displaying the event-details on the…
12c2da3 
… event page

    #380
jcremerius added a commit that referenced this issue Jan 19, 2018
@jcremerius
Add specific css for the event title and description when having the …
9472347 
…grid with 2 items per row

    #380
@MariusDanner MariusDanner mentioned this issue Jan 26, 2018
Closed
5 tasks
MariusDanner added a commit that referenced this issue Jan 30, 2018
@MariusDanner
Add image to all_events on event index. #380
df026db
MariusDanner added a commit that referenced this issue Jan 30, 2018
@MariusDanner
Fix missing translation. #380
9df66c7
MariusDanner added a commit that referenced this issue Jan 30, 2018
@MariusDanner
Change default picture on event index page. #380
2df72eb
@emanuel-metzenthin
Copy link

Most PO requests have been fixed in #379

@zhamanakov
Copy link
Author

zhamanakov commented Feb 2, 2018 •
edited
Loading

Default picture is now way too big (1,7 Mb).
It should be max. 100 Kb.

Custom pictures should be also compress to max 100 Kb.

@nikriek
Copy link
Contributor

nikriek commented Feb 3, 2018

#521

@zhamanakov
Copy link
Author

zhamanakov commented Feb 4, 2018 •
edited
Loading

Why contains every tile "Max. Spieleranzahl" and not "Anmeldung: bis XXXX | Start: XXXX"?

Screen Shot 2018-02-04 at 13.11.38.png

jcremerius added a commit that referenced this issue Feb 4, 2018
@jcremerius
Modify the position of start date and sign in date, so that they are …
302c29d 
…in two rows

    #380
@jcremerius
Copy link
Contributor

As issue 379 is not done yet, the event tiles are not up to date on dev. When 379 is approved, we can open a pull request and merge to dev. On our branch, the tiles look different. Is it okay to have Startdatum and Anmeldedatum in two rows, becasue they take too much space?
It would look like this.
unbenannt

Thank you!

@JakobEdding
Copy link
Member

I just enabled automatic deployment of your branch to sport-portal-pr on Heroku as we have that deployment available again and it seems @zhamanakov is eager to give feedback. ;) Or would you like to have the deployment for feedback on #379 @emanuel-metzenthin @MariusDanner?

@zhamanakov
Copy link
Author

@jcremerius yes, 2 lines for Startdatum and Anmeldedatum.
But name should be in max 1 line.

jcremerius added a commit that referenced this issue Feb 6, 2018
@jcremerius
Modify the tile title, so there is no break line when a white space i…
34fbfc3 
…s in the name

    #380
jcremerius added a commit that referenced this issue Feb 6, 2018
@jcremerius
Merge branch 'dev' into flexibus/#380/events-view-as-tiles
67f81a9 
# Conflicts:
#	app/assets/stylesheets/tile.css
#	app/models/event.rb
jcremerius added a commit that referenced this issue Feb 6, 2018
@jcremerius
Merge dev to this branch
9f9e9cc 
    #380
@jcremerius jcremerius mentioned this issue Feb 6, 2018
Merged
@hpi-swt2 hpi-swt2 deleted a comment from jcremerius Feb 6, 2018
jcremerius added a commit that referenced this issue Feb 6, 2018
@jcremerius
Remove an unnecessary white space in the event_description method
ba3369d 
    #380
jcremerius added a commit that referenced this issue Feb 7, 2018
@jcremerius
Merge branch 'dev' into flexibus/#380/events-view-as-tiles
d9a909f
Blubl added a commit that referenced this issue Feb 8, 2018
@Blubl
Merge branch 'dev' into flexibus/#380/events-view-as-tiles
83cdec1
jcremerius added a commit that referenced this issue Feb 8, 2018
@jcremerius
Merge branch 'dev' into flexibus/#380/events-view-as-tiles
efc6962
jcremerius added a commit that referenced this issue Feb 8, 2018
@jcremerius
Merge branch 'dev' into flexibus/#380/events-view-as-tiles
b4be760
JakobEdding pushed a commit that referenced this issue Feb 8, 2018
Merge pull request #557 from hpi-swt2/flexibus/#380/events-view-as-tiles
e165c14 
Flexibus/#380/events view as tiles
@ghost ghost removed the review label Feb 8, 2018
@JakobEdding JakobEdding reopened this Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcremerius jcremerius

@MariusDanner MariusDanner

Labels
epic design Team Flexibus
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nikriek @jcremerius @JakobEdding @zhamanakov @emanuel-metzenthin @MariusDanner