Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Velbus add quality_scale.yaml #131377

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
+70 −1
Open

Velbus add quality_scale.yaml #131377

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d17a854
Velbus add quality_scale.yaml
cereal2nd Nov 23, 2024
83fbfe4
updates
cereal2nd Nov 24, 2024
5433cc3
fix wording
cereal2nd Nov 24, 2024
4cb17f7
Merge branch 'dev' into velbusqualityscale
cereal2nd Nov 24, 2024
7fc4d69
Update homeassistant/components/velbus/quality_scale.yaml
cereal2nd Nov 24, 2024
5c5f3cb
Merge branch 'dev' into velbusqualityscale
cereal2nd Nov 24, 2024
12b3a1d
Merge branch 'dev' into velbusqualityscale
cereal2nd Nov 25, 2024
0959fa3
Merge branch 'dev' into velbusqualityscale
cereal2nd Nov 25, 2024
2613977
Merge branch 'dev' into velbusqualityscale
cereal2nd Nov 25, 2024
195e15d
Update homeassistant/components/velbus/quality_scale.yaml
cereal2nd Nov 26, 2024
ff27890
Merge branch 'dev' into velbusqualityscale
cereal2nd Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions homeassistant/components/velbus/quality_scale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
rules:
# Bronze
action-setup: todo
appropriate-polling:
status: exempt
comment: |
This integration does not do polling.
cereal2nd marked this conversation as resolved.
Show resolved Hide resolved
brands: done
common-modules: done
config-flow-test-coverage: done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is config-flow todo, while test-coverage is done?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the config flow is only missing data_descriptions

config-flow: todo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not have a user configurable name in the config fow. Not a blocker, just wanted to mention it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what name should be selected?
some people will need more then 1 of these, so they will need to know what entry is what connection

dependency-transparency: done
docs-actions: todo
docs-high-level-description: todo
docs-installation-instructions: todo
docs-removal-instructions: todo
entity-event-setup: todo
entity-unique-id: done
has-entity-name: todo
runtime-data: todo
test-before-configure: done
test-before-setup: todo
unique-config-entry: done
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does usb get unique id and manual setup only abort on common port?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be some legacy implementation, i already have a fix locally, will push it aftert this PR


# Silver
action-exceptions: todo
config-entry-unloading: done
docs-configuration-parameters: todo
docs-installation-parameters: todo
entity-unavailable: todo
integration-owner: done
log-when-unavailable: done
parallel-updates: todo
reauthentication-flow:
status: exempt
comment: |
This integration does not require authentication.
test-coverage: todo
# Gold
devices: done
diagnostics: done
discovery-update-info: done
discovery: done
docs-data-update: todo
docs-examples: todo
docs-known-limitations: todo
docs-supported-devices: todo
docs-supported-functions: todo
docs-troubleshooting: todo
docs-use-cases: todo
dynamic-devices: done
entity-category: done
cereal2nd marked this conversation as resolved.
Show resolved Hide resolved
entity-device-class: todo
entity-disabled-by-default: done
entity-translations: todo
exception-translations: todo
icon-translations: todo
reconfiguration-flow: todo
repair-issues:
status: exempt
comment: |
This integration doesn't have any cases where raising an issue is needed.
stale-devices: done
# Platinum
async-dependency: done
inject-websession:
status: exempt
comment: |
This integration communicates via serial/usb/tcp and does not require a web session.
strict-typing: done
1 change: 0 additions & 1 deletion script/hassfest/quality_scale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,7 +1089,6 @@
"v2c",
"vallox",
"vasttrafik",
"velbus",
"velux",
"venstar",
"vera",
Expand Down