Velbus add quality_scale.yaml

[cereal2nd]

Proposed change

Add quality_scale.yaml to vvelbus

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @brefra, mind taking a look at this pull request as it has been labeled with an integration (velbus) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of velbus can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign velbus Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[allenporter]

Reading through the integration code and the checklist it seems like a bunch of the rules marked as done were not done. Perhaps you need to look a lot closer at the rules? or i'm misunderstanding a bunch of what is going on here.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[cereal2nd]

@allenporter it seems i misunderstood some of the requirements, after reading through the docs a second time and looking at some code.

i just updated the file

[joostlek]

how is config-flow todo, while test-coverage is done?

[cereal2nd]

the config flow is only missing data_descriptions

[joostlek]

We should not have a user configurable name in the config fow. Not a blocker, just wanted to mention it

[cereal2nd]

what name should be selected?
some people will need more then 1 of these, so they will need to know what entry is what connection

[joostlek]

Why does usb get unique id and manual setup only abort on common port?

[cereal2nd]

this seems to be some legacy implementation, i already have a fix locally, will push it aftert this PR