Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential fix for textfile path issues (#7) #8

Merged
merged 3 commits into from
Apr 6, 2024

Conversation

jeffgca
Copy link
Contributor

@jeffgca jeffgca commented Apr 5, 2024

I'm trying to guess the installed directory of the package using process.argv, but I'm unsure if this will break once the cli is installed via bun on a system.

Fixes #7

…directory of the package using process.argv
@fabio-nettis
Copy link
Member

fabio-nettis commented Apr 5, 2024

@jeffgca Could we not be using something like __dirname instead? This looks a bit unstable. Something along the lines of:

path.join(__dirname, "../ascii", `${name}.txt`);

You can check the build output here.

@fabio-nettis fabio-nettis self-requested a review April 5, 2024 19:51
@fabio-nettis fabio-nettis changed the title potential fix for #7 fix: potential fix for textfile path issues (#7) Apr 5, 2024
@fabio-nettis fabio-nettis removed their request for review April 5, 2024 20:12
Copy link
Contributor Author

@jeffgca jeffgca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with __dirname, which I completely forgot about.

@fabio-nettis
Copy link
Member

@jeffgca Checks don't pass yet.

@jeffgca
Copy link
Contributor Author

jeffgca commented Apr 6, 2024

@jeffgca Checks don't pass yet.

Oh yeah, fixed that. It takes a really long time for the checks to run, wish I could run them before committing?

@fabio-nettis fabio-nettis added the bug Something isn't working label Apr 6, 2024
@fabio-nettis
Copy link
Member

LGTM.

@fabio-nettis fabio-nettis merged commit eec286e into hellhub-collective:main Apr 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical: Unable to resolve ascii art textfile paths
2 participants