Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - adaptive downsampling of volume rendering based on framerate #591

Merged
merged 91 commits into from
Jul 3, 2024
Merged

Feature - adaptive downsampling of volume rendering based on framerate #591

merged 91 commits into from
Jul 3, 2024

Commits on Apr 25, 2024

  1. temp: see what reduced viewport looks like

    @seankmartin
    seankmartin committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0d7a69a View commit details
    Browse the repository at this point in the history

  2. temp: set downsampling factor, ds max proj

    @seankmartin
    seankmartin committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    316bcf5 View commit details
    Browse the repository at this point in the history

  3. temp: quick experiment with interploation

    @seankmartin
    seankmartin committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8be038b View commit details
    Browse the repository at this point in the history

  4. Revert "temp: quick experiment with interploation" 

    This reverts commit 8be038b.
    @seankmartin
    seankmartin committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    009c724 View commit details
    Browse the repository at this point in the history

  5. feat: 4x downsampling with linear interpolation

    @seankmartin
    seankmartin committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    cb626cd View commit details
    Browse the repository at this point in the history

  6. temp: see if build updating

    @seankmartin
    seankmartin committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c6b0617 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. temp: keep changes

    @seankmartin
    seankmartin committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ce53842 View commit details
    Browse the repository at this point in the history

  2. feat: downsample on camera move - render again if settled

    @seankmartin
    seankmartin committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7a3fa12 View commit details
    Browse the repository at this point in the history

  3. temp: single frame chck

    @seankmartin
    seankmartin committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    37dc166 View commit details
    Browse the repository at this point in the history

  4. fix: remove logs

    @seankmartin
    seankmartin committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6c95d5f View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. feat: framerate counter

    @seankmartin
    seankmartin committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    43ed997 View commit details
    Browse the repository at this point in the history

  2. feat: downsample adaptively based on framerate

    @seankmartin
    seankmartin committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d27a1c7 View commit details
    Browse the repository at this point in the history

  3. refactor: remove variable

    @seankmartin
    seankmartin committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0f189eb View commit details
    Browse the repository at this point in the history

  4. feat: don't downsample after picking

    @seankmartin
    seankmartin committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6b35b24 View commit details
    Browse the repository at this point in the history

  5. chore: remove debug log

    @seankmartin
    seankmartin committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9ff56a7 View commit details
    Browse the repository at this point in the history

  6. fix: copy over the depth buffer from offscreen

    @seankmartin
    seankmartin committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    cbc065a View commit details
    Browse the repository at this point in the history

  7. refactor: rename VR variables

    @seankmartin
    seankmartin committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0352605 View commit details
    Browse the repository at this point in the history

  8. feat: downsample VR based on XY data res or framerate when moving

    @seankmartin
    seankmartin committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a521a59 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. fix: size downsample based on n visible chunks and chunk re

    @seankmartin
    seankmartin committed May 2, 2024
    Configuration menu
    Copy the full SHA
    05d9988 View commit details
    Browse the repository at this point in the history

  2. chore: format

    @seankmartin
    seankmartin committed May 2, 2024
    Configuration menu
    Copy the full SHA
    544664b View commit details
    Browse the repository at this point in the history

  3. fix: remove temp change

    @seankmartin
    seankmartin committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a2101a1 View commit details
    Browse the repository at this point in the history

  4. refactor: removed unsed call

    @seankmartin
    seankmartin committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8d8a8a3 View commit details
    Browse the repository at this point in the history

  5. feat: remove linear interpolation in downsample

    @seankmartin
    seankmartin committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d448081 View commit details
    Browse the repository at this point in the history

  6. refactor: remove magic numbers

    @seankmartin
    seankmartin committed May 2, 2024
    Configuration menu
    Copy the full SHA
    34499cc View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. refactor: clarify frame rate

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    425e09f View commit details
    Browse the repository at this point in the history

  2. test: add framerate calc test

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6b43762 View commit details
    Browse the repository at this point in the history

  3. fix: remove downsampling based on VR chunk res due to possible undesi… 

    …red bevhaiour with other transparent layers
    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    fe266c0 View commit details
    Browse the repository at this point in the history

  4. fix: don't double draw opaque layers

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    eb292ef View commit details
    Browse the repository at this point in the history

  5. feat: pow2 downample

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8b30708 View commit details
    Browse the repository at this point in the history

  6. feat: keep downsample to the highest needed this camera move 

    this is a bit agressive, but smooths the jutters that occur otherwise
might revisit for cleaner strategy
    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5007e2b View commit details
    Browse the repository at this point in the history

  7. feat: setting to turn off adaptive downsampling

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5d25cdb View commit details
    Browse the repository at this point in the history

  8. feat: use median frame count for more stability

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    aebe5e4 View commit details
    Browse the repository at this point in the history

  9. feat: calculate frames over larger window for more smoothness

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0f51de4 View commit details
    Browse the repository at this point in the history

  10. feat: less popping in downsample

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4898c36 View commit details
    Browse the repository at this point in the history

  11. fix: respect max downsample rate

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    14aac39 View commit details
    Browse the repository at this point in the history

  12. fix: don't use magic number

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    00de472 View commit details
    Browse the repository at this point in the history

  13. revert: go back to smaller frame count

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    f874d54 View commit details
    Browse the repository at this point in the history

  14. feat: allow to choose between mean and median in framerate

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6b1167d View commit details
    Browse the repository at this point in the history

  15. fix: correct frame average

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e9779a2 View commit details
    Browse the repository at this point in the history

  16. feat: reduce size of frame counter so that bad frames take impact sooner

    @seankmartin
    seankmartin committed May 3, 2024
    Configuration menu
    Copy the full SHA
    202145f View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. feat: store frame deltas, not raw frame times

    @seankmartin
    seankmartin committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7fe0728 View commit details
    Browse the repository at this point in the history

  2. refactor: move downsample calculation

    @seankmartin
    seankmartin committed May 10, 2024
    Configuration menu
    Copy the full SHA
    3e04498 View commit details
    Browse the repository at this point in the history

  3. feat: track if downsampled this move

    @seankmartin
    seankmartin committed May 10, 2024
    Configuration menu
    Copy the full SHA
    38fa133 View commit details
    Browse the repository at this point in the history

  4. feat: keep more influence on history to avoid flipping back and forth… 

    … between buffer sizes
    @seankmartin
    seankmartin committed May 10, 2024
    Configuration menu
    Copy the full SHA
    620292f View commit details
    Browse the repository at this point in the history

  5. feat: allow full history influence

    @seankmartin
    seankmartin committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8d36912 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. feat: add frame rate monitor with gl query

    @seankmartin
    seankmartin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    97eb116 View commit details
    Browse the repository at this point in the history

  2. feat: use gl query times in perspective panel

    @seankmartin
    seankmartin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5865899 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feature/increase-vr-performance

    @seankmartin
    seankmartin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3a963e1 View commit details
    Browse the repository at this point in the history

  4. feat: add more frame timing options

    @seankmartin
    seankmartin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7cdff67 View commit details
    Browse the repository at this point in the history

  5. feat: persist a high downsampling over a number of frames

    @seankmartin
    seankmartin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f60c734 View commit details
    Browse the repository at this point in the history

  6. feat: tweak settings to try improve smoothness of rendering

    @seankmartin
    seankmartin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    12d75fe View commit details
    Browse the repository at this point in the history

  7. refactor: simplify camera move check

    @seankmartin
    seankmartin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    61d68e5 View commit details
    Browse the repository at this point in the history

  8. feat: speed up calculation of frame time

    @seankmartin
    seankmartin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1c201d3 View commit details
    Browse the repository at this point in the history

  9. revert: don't use gl query for framerate

    @seankmartin
    seankmartin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1301ec1 View commit details
    Browse the repository at this point in the history

  10. feat: tweak settings for smoothness

    @seankmartin
    seankmartin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8f43629 View commit details
    Browse the repository at this point in the history

  11. fix: jumpiness between adaptive sampling

    @seankmartin
    seankmartin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    489cb37 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. feat: better trade off between smoothness and reactiveness

    @seankmartin
    seankmartin committed May 29, 2024
    Configuration menu
    Copy the full SHA
    ee3cef2 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge branch 'master' into feature/increase-vr-performance-no-gl-query

    @seankmartin
    seankmartin committed May 30, 2024
    Configuration menu
    Copy the full SHA
    3ae472d View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. refactor: clearer adaptive downsample setting

    @seankmartin
    seankmartin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    7dca7fb View commit details
    Browse the repository at this point in the history

  2. refactor: clean up downsampling framerate class

    @seankmartin
    seankmartin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    a8b3a22 View commit details
    Browse the repository at this point in the history

  3. feat: don't crash framerate calculator if negative delta

    @seankmartin
    seankmartin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e867258 View commit details
    Browse the repository at this point in the history

  4. test: add test for downsampling calculation

    @seankmartin
    seankmartin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    44ef94f View commit details
    Browse the repository at this point in the history

  5. feat: handle framerate args instead of error

    @seankmartin
    seankmartin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    be9deb0 View commit details
    Browse the repository at this point in the history

  6. feat: improve performance of max downsample tracking

    @seankmartin
    seankmartin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    cfd8c89 View commit details
    Browse the repository at this point in the history

  7. test: test new downsample calculation

    @seankmartin
    seankmartin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    baf2a00 View commit details
    Browse the repository at this point in the history

  8. refactor: remove extranous doc

    @seankmartin
    seankmartin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    66305fc View commit details
    Browse the repository at this point in the history

  9. feat: separate VR buffer to transparent

    @seankmartin
    seankmartin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    64ca78f View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. feat: add context tracking of continous camera motion

    @seankmartin
    seankmartin committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    742a1bd View commit details
    Browse the repository at this point in the history

  2. feat: link perspective panel to context camera tracking 

    Also only redraw if volume rendering is present after camera motion
    @seankmartin
    seankmartin committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    487e06b View commit details
    Browse the repository at this point in the history

  3. fix: rename camera movement in layers

    @seankmartin
    seankmartin committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    59d8ec7 View commit details
    Browse the repository at this point in the history

  4. feat: mark rotation in panel as continuous

    @seankmartin
    seankmartin committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    dfef0b6 View commit details
    Browse the repository at this point in the history

  5. feat: mark rendered data panel actions as camera move

    @seankmartin
    seankmartin committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    d66c649 View commit details
    Browse the repository at this point in the history

  6. feat: mark slice rotations as continous camera

    @seankmartin
    seankmartin committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    75de9a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. refactor: unify naming of camera motion in contexts

    @seankmartin
    seankmartin committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    6c639b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'feature/continous-camera-movement-tracking' into featur… 

    …e/increase-vr-performance-no-gl-query
    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    9940a88 View commit details
    Browse the repository at this point in the history

  2. fix: cleanup after merge

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    4579b5d View commit details
    Browse the repository at this point in the history

  3. feat: add camera move start signal

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6e60b7c View commit details
    Browse the repository at this point in the history

  4. fix: track downsampling on/off for new context

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    499515f View commit details
    Browse the repository at this point in the history

  5. refactor: clarify state handling

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    8493c15 View commit details
    Browse the repository at this point in the history

  6. fix: remove debug log

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e703276 View commit details
    Browse the repository at this point in the history

  7. fix: remove debug log

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    50e3162 View commit details
    Browse the repository at this point in the history

  8. feat: lower max downsampling to 4

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    bd1eb8c View commit details
    Browse the repository at this point in the history

  9. feat: gl based timing

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e60a1b7 View commit details
    Browse the repository at this point in the history

  10. feat: change max downsample to 4 for parity

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    405e1d7 View commit details
    Browse the repository at this point in the history

  11. fix: correct last commit

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2ad6fe5 View commit details
    Browse the repository at this point in the history

  12. fix: remove debug log

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a686ac7 View commit details
    Browse the repository at this point in the history

  13. feat(python): add control for adaptive downsampling setting

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    60ca39c View commit details
    Browse the repository at this point in the history

  14. feat(Python): add wireframe setting to python viewer state

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c9ef6d9 View commit details
    Browse the repository at this point in the history

  15. refactor: rename enum for transparent to consistent casing

    @seankmartin
    seankmartin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    491ac3c View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. fix: only calculate downsampling factor if VR enabled

    @seankmartin
    seankmartin committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    c2b898a View commit details
    Browse the repository at this point in the history

  2. fix: correct persistence of max downsampling ratio across a camera mo… 

    …vement

this avoids popping back and forth between downsampling ratios
    @seankmartin
    seankmartin committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    bee6b60 View commit details
    Browse the repository at this point in the history