Feature - adaptive downsampling of volume rendering based on framerate #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8be038b.
…red bevhaiour with other transparent layers
this is a bit agressive, but smooths the jutters that occur otherwise might revisit for cleaner strategy
Also only redraw if volume rendering is present after camera motion
seankmartin
changed the title
seankmartin
changed the title
…e/increase-vr-performance-no-gl-query
jbms
reviewed
Jul 1, 2024
| @@ -295,6 +295,7 @@ class TrackableViewerState extends CompoundTrackable { | |||
| this.add("layers", viewer.layerSpecification); | |||
| this.add("showAxisLines", viewer.showAxisLines); | |||
| this.add("wireFrame", viewer.wireFrame); | |||
| this.add("enableAdaptiveDownsampling", viewer.enableAdaptiveDownsampling); | |||
There was a problem hiding this comment.
Add corresponding option to Python viewer_state.py
jbms
reviewed
Jul 1, 2024
…vement this avoids popping back and forth between downsampling ratios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall idea is that a setting (currently on by default) would allow a global downsampling in XY resolution for 3D panels of transparent layers during camera movement if the framerate drops below a certain threshold.
All of this is open to change, but currently:
Target FPS is 60
The mean framerate over a running 6 frames after a camera move is initiated is calculated
If this median framerate drops below 60, a downsampling rate of 2, 4, or 8 is chosen based on how far from 60 the framerate is.
If a downsample is detected, then during this camera movement, the downsampling rate will never go back above the highest downsample rate detected for about the last second
When the camera stops moving, a fresh full resolution drawing is requested after 300ms
To update: