Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data collection] Restore position to last active task when restoring from draft #2871

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Merge branch 'master' into ashobhit/2832/draft-position

7c4c0cc
Select commit
Loading
Failed to load commit list.
Open

[Data collection] Restore position to last active task when restoring from draft #2871

Merge branch 'master' into ashobhit/2832/draft-position
7c4c0cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 2, 2024 in 1s

61.15% (-0.04%) compared to c982a50

View this Pull Request on Codecov

61.15% (-0.04%) compared to c982a50

Details

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.15%. Comparing base (c982a50) to head (7c4c0cc).

Files with missing lines Patch % Lines
...d/persistence/local/room/converter/ConverterExt.kt 0.00% 2 Missing ⚠️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 0.00% 2 Missing ⚠️
...android/ground/model/submission/DraftSubmission.kt 0.00% 1 Missing ⚠️
...istence/local/room/entity/DraftSubmissionEntity.kt 0.00% 1 Missing ⚠️
.../android/ground/repository/SubmissionRepository.kt 0.00% 1 Missing ⚠️
...ground/ui/datacollection/DataCollectionFragment.kt 0.00% 0 Missing and 1 partial ⚠️
...oogle/android/ground/ui/home/HomeScreenFragment.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2871      +/-   ##
============================================
- Coverage     61.19%   61.15%   -0.04%     
- Complexity     1183     1184       +1     
============================================
  Files           267      267              
  Lines          6396     6403       +7     
  Branches        914      915       +1     
============================================
+ Hits           3914     3916       +2     
- Misses         1943     1950       +7     
+ Partials        539      537       -2
Files with missing lines Coverage Δ
.../src/main/java/com/google/android/ground/Config.kt 100.00% <ø> (ø)
...oid/ground/persistence/local/room/LocalDatabase.kt 100.00% <ø> (ø)
...round/ui/datacollection/DataCollectionViewModel.kt 73.60% <100.00%> (+2.03%) ⬆️
...android/ground/model/submission/DraftSubmission.kt 0.00% <0.00%> (ø)
...istence/local/room/entity/DraftSubmissionEntity.kt 0.00% <0.00%> (ø)
.../android/ground/repository/SubmissionRepository.kt 18.60% <0.00%> (ø)
...ground/ui/datacollection/DataCollectionFragment.kt 54.00% <0.00%> (-2.00%) ⬇️
...oogle/android/ground/ui/home/HomeScreenFragment.kt 54.45% <0.00%> (-0.55%) ⬇️
...d/persistence/local/room/converter/ConverterExt.kt 78.10% <0.00%> (-0.52%) ⬇️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 16.86% <0.00%> (-0.20%) ⬇️
View more details on Codecov