Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data collection] Restore position to last active task when restoring from draft #2871

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Nov 24, 2024

Fixes #2832

Reuses currentTaskId mechanism to set the initial task position when restoring from draft.

draft-position.webm

@sufyanAbbasi there is some weirdness with task sequence when moving to previous task from restored position. Do you have any ideas?

@sufyanAbbasi @gino-m PTAL?

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.16%. Comparing base (f2441dd) to head (0e46c8b).

Files with missing lines Patch % Lines
...d/persistence/local/room/converter/ConverterExt.kt 0.00% 2 Missing ⚠️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 0.00% 2 Missing ⚠️
...android/ground/model/submission/DraftSubmission.kt 0.00% 1 Missing ⚠️
...istence/local/room/entity/DraftSubmissionEntity.kt 0.00% 1 Missing ⚠️
.../android/ground/repository/SubmissionRepository.kt 0.00% 1 Missing ⚠️
...ground/ui/datacollection/DataCollectionFragment.kt 0.00% 0 Missing and 1 partial ⚠️
...oogle/android/ground/ui/home/HomeScreenFragment.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2871      +/-   ##
============================================
- Coverage     61.20%   61.16%   -0.04%     
- Complexity     1183     1184       +1     
============================================
  Files           266      266              
  Lines          6346     6353       +7     
  Branches        903      904       +1     
============================================
+ Hits           3884     3886       +2     
- Misses         1933     1940       +7     
+ Partials        529      527       -2     
Files with missing lines Coverage Δ
.../src/main/java/com/google/android/ground/Config.kt 100.00% <ø> (ø)
...oid/ground/persistence/local/room/LocalDatabase.kt 100.00% <ø> (ø)
...round/ui/datacollection/DataCollectionViewModel.kt 73.60% <100.00%> (+2.03%) ⬆️
...android/ground/model/submission/DraftSubmission.kt 0.00% <0.00%> (ø)
...istence/local/room/entity/DraftSubmissionEntity.kt 0.00% <0.00%> (ø)
.../android/ground/repository/SubmissionRepository.kt 18.60% <0.00%> (ø)
...ground/ui/datacollection/DataCollectionFragment.kt 54.00% <0.00%> (-2.00%) ⬇️
...oogle/android/ground/ui/home/HomeScreenFragment.kt 54.45% <0.00%> (-0.55%) ⬇️
...d/persistence/local/room/converter/ConverterExt.kt 78.10% <0.00%> (-0.52%) ⬇️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 16.86% <0.00%> (-0.20%) ⬇️

@shobhitagarwal1612 shobhitagarwal1612 changed the title [Data collection] Restore position to last task when restoring draft [Data collection] Restore position to last active task when restoring draft Nov 24, 2024
@shobhitagarwal1612 shobhitagarwal1612 changed the title [Data collection] Restore position to last active task when restoring draft [Data collection] Restore position to last active task when restoring from draft Nov 24, 2024
@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as ready for review November 27, 2024 18:08
@auto-assign auto-assign bot requested a review from gino-m November 27, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data collection] Data collection returns to first task/step after draft state restored
3 participants