Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully drain messages during client.Stop #541

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fully drain messages during client.Stop #541

merged 1 commit into from
Nov 7, 2024

Commits on Nov 7, 2024

  1. Fully drain messages during client.Stop 

    Messages buffered by `SortLoop` were previously not drained and therefore not acked, leading to wrong metric counters.

The gist of this change is that `SortLoop` now waits for its buffered messages to be drained before returning.

PiperOrigin-RevId: 694092374
    @torsm @copybara-github
    torsm authored and copybara-github committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    94a0688 View commit details
    Browse the repository at this point in the history