Fully drain messages during client.Stop
#541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/693705921
branch
5 times, most recently
from
658ae27
to
c15716f
Compare
Messages buffered by `SortLoop` were previously not drained and therefore not acked, leading to wrong metric counters. The gist of this change is that `SortLoop` now waits for its buffered messages to be drained before returning. PiperOrigin-RevId: 694092374
copybara-service
bot
force-pushed
the
cl/693705921
branch
from
c15716f
to
94a0688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully drain messages during
client.StopMessages buffered by
SortLoopwere previously not drained and therefore not acked, leading to wrong metric counters.The gist of this change is that
SortLoopnow waits for its buffered messages to be drained before returning.