Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Misc. build and warning fixes to pass CI and compile with recent SCons and GCC/Clang #98900

Merged
merged 21 commits into from
Nov 7, 2024

Commits on Nov 6, 2024

  1. [HTML5] Scons now expects "emcc" to be in PATH.

    No longer parse emscripten/emsdk config to detect emcc/node paths.
    Use WhereIs to find "emcc" and "node", look for "node_modules" in "emcc"
    path.
    
    (cherry picked from commit 7998745)
    (cherry picked from commit 2d5f9c5)
    Faless authored and akien-mga committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0948ca9 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    6bf2e63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2973cce View commit details
    Browse the repository at this point in the history
  3. SCons: Fix Python 3.12 SyntaxError with regex escape sequences

    (cherry picked from commit b362976)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a2e598b View commit details
    Browse the repository at this point in the history
  4. Windows: Fix build with SCons 4.2.0

    (cherry picked from commit c191cfb)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c5d5ba9 View commit details
    Browse the repository at this point in the history
  5. Mono: Replace distutils function with shutil equivalent

    Fixes godotengine#91154.
    
    (cherry picked from commit ee61ad4)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c558ce1 View commit details
    Browse the repository at this point in the history
  6. Android: Replace deprecated distutils LooseVersion usage

    (cherry picked from commit 9e9ea71)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4da4280 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6c3befc View commit details
    Browse the repository at this point in the history
  8. Fix some array size function definition mismatch.

    (cherry picked from commit 55845ba)
    Faless authored and akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d70e80e View commit details
    Browse the repository at this point in the history
  9. [Core] Use std type traits to check operations triviality.

    (cherry picked from commit 6f02183)
    Faless authored and akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    9a87271 View commit details
    Browse the repository at this point in the history
  10. macOS: Fix sprintf deprecation warning

    Co-authored-by: bruvzg <[email protected]>
    (cherry picked from commit a297a69)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    fd669b9 View commit details
    Browse the repository at this point in the history
  11. Fix warnings found by Emscripten 3.1.10

    Fix `-Wunused-but-set-variable`, `-Wunqualified-std-cast-call`, and
    `-Wliteral-range` warnings.
    
    (cherry picked from commit d8935b2)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e6cab51 View commit details
    Browse the repository at this point in the history
  12. Fix some Clang -Wunused-but-set-variable warnings

    (cherry picked from commit e771804)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    9418bc4 View commit details
    Browse the repository at this point in the history
  13. Fix building VHACD with GCC 13.

    Fixes the following error:
    thirdparty/vhacd/inc/vhacdICHull.h:46:31: error: 'uint32_t' does not name a type
       46 |     ICHullError Process(const uint32_t nPointsCH, const double minVolume = 0.0);
          |                               ^~~~~~~~
    
    Note the upstream version of the third party library is not affected.
    
    (cherry picked from commit a648d83)
    marxin authored and akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    74b4fb6 View commit details
    Browse the repository at this point in the history
  14. Add missing stdint.h includes for GCC 13+

    Fixes godotengine#77927.
    
    (cherry picked from commit 10676e7)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f9c0cd6 View commit details
    Browse the repository at this point in the history
  15. Fix GCC 14 -Wtemplate-id-cdtor warnings

    Fixes godotengine#91206.
    
    (cherry picked from commit a8ff47b)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ea1dbdc View commit details
    Browse the repository at this point in the history
  16. Fix Xcode deprecation warning about sprintf usage

    (cherry picked from commit b778c5c)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    87be97b View commit details
    Browse the repository at this point in the history
  17. Fix various Clang -Wunused-but-set-variable warnings

    (cherry picked from commit 74d569b)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    172dd99 View commit details
    Browse the repository at this point in the history
  18. SCons: Disable Clang -Wordered-compare-function-pointers warning

    It's raised for us on many comparators implemented to be able to store a struct
    in `Set` or `Map` (who rely on `operator<` internally). In the cases I reviewed
    we don't actually care about the ordering and we use the struct's function
    pointers as that's the only distinctive data available.
    
    (cherry picked from commit 802810c)
    (cherry picked from commit 4c79dcc)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5d023b5 View commit details
    Browse the repository at this point in the history
  19. Ensure flags are applied to CVTT options

    (cherry picked from commit 709aa8a)
    madmiraal authored and akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e71926c View commit details
    Browse the repository at this point in the history
  20. certs: Sync with Mozilla bundle as of Oct 19, 2024

    bagder/ca-bundle@4d3fe66
    
    Document matching mozilla-release changeset.
    
    (cherry picked from commit eb41ff0)
    akien-mga committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b35c7ee View commit details
    Browse the repository at this point in the history