[3.2] Misc. build and warning fixes to pass CI and compile with recent SCons and GCC/Clang #98900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
force-pushed
the
3.2-ci-build-warnings-fixes
branch
2 times, most recently
from
a5a5f01
to
27361ff
Compare
akien-mga
force-pushed
the
3.2-ci-build-warnings-fixes
branch
3 times, most recently
from
5d4c988
to
cc0e1d2
Compare
akien-mga
force-pushed
the
3.2-ci-build-warnings-fixes
branch
7 times, most recently
from
98d39a2
to
676a6e2
Compare
(cherry picked from commit b362976)
(cherry picked from commit c191cfb)
Fixes godotengine#91154. (cherry picked from commit ee61ad4)
(cherry picked from commit 9e9ea71)
(cherry picked from commit 55845ba)
(cherry picked from commit 6f02183)
Co-authored-by: bruvzg <[email protected]> (cherry picked from commit a297a69)
Fix `-Wunused-but-set-variable`, `-Wunqualified-std-cast-call`, and `-Wliteral-range` warnings. (cherry picked from commit d8935b2)
(cherry picked from commit e771804)
Fixes the following error:
thirdparty/vhacd/inc/vhacdICHull.h:46:31: error: 'uint32_t' does not name a type
46 | ICHullError Process(const uint32_t nPointsCH, const double minVolume = 0.0);
| ^~~~~~~~
Note the upstream version of the third party library is not affected.
(cherry picked from commit a648d83)
Fixes godotengine#77927. (cherry picked from commit 10676e7)
Fixes godotengine#91206. (cherry picked from commit a8ff47b)
(cherry picked from commit b778c5c)
(cherry picked from commit 74d569b)
It's raised for us on many comparators implemented to be able to store a struct in `Set` or `Map` (who rely on `operator<` internally). In the cases I reviewed we don't actually care about the ordering and we use the struct's function pointers as that's the only distinctive data available. (cherry picked from commit 802810c) (cherry picked from commit 4c79dcc)
(cherry picked from commit 709aa8a)
bagder/ca-bundle@4d3fe66 Document matching mozilla-release changeset. (cherry picked from commit eb41ff0)
akien-mga
force-pushed
the
3.2-ci-build-warnings-fixes
branch
from
676a6e2
to
b35c7ee
Compare
|
Alright, finally got CI passing on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.2equivalent to [3.4] Misc. build and warning fixes to pass CI and compile with recent SCons and GCC/Clang #98864 and [3.3] Misc. build and warning fixes to pass CI and compile with recent SCons and GCC/Clang #98867 (cherry-picked mostly from the latter).Likewise, this doesn't mean restarting active support for the
3.3branch, this is just a code/history preservation improvement.