Use double comments in shader template light functions #97024
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a second layer of commenting to the
light()
function of CanvasItem and Spatial shader templates, so if you select and uncomment thelight()
function, you have a valid shader.Current behavior:
If you create a new Spatial or CanvasItem shader, the template comes with a commented out
light()
function:But if you select it and uncomment it with
ctrl+k
, you have a shader with a compile error, since the template only uses a single level of commenting:This PR:
Tested on the CI artifact:
Shader template:
Select and uncomment the light function, and you have a valid shader: