Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Namespace migration (narrow) : sdformat #1026

Closed
wants to merge 2 commits into from
Closed

ign -> gz Namespace migration (narrow) : sdformat #1026

wants to merge 2 commits into from

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Part of gazebo-tooling/release-tools#711, more narrow alternative to #1022

Summary

This is an alternative to #1022 (actually using some commits from that branch) that is narrower in scope. It avoids most macro changes in an attempt to simplify the review process.

Once these namespace changes start being merged, things will break, so we will try to merge them all relatively close together in time.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Migrate 'namespace ignition' -> 'namespace gz'
2879b92 
~~~
sed -i -e 's@namespace ignition@namespace gz@g' \
  $(grep -rlI 'namespace ignition' .)
~~~

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Migrate 'ignition::' -> 'gz::'
e7c9344 
~~~
sed -i -e 's@ignition::@gz::@g' \
  $(grep -rlI 'ignition::' .)
~~~

Excluded changes to Changelog.md and Migration.md

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner May 22, 2022 19:59
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 22, 2022
@methylDragon methylDragon mentioned this pull request May 22, 2022
Closed
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 23, 2022
@chapulina
Copy link
Contributor

#1022 got in

@chapulina chapulina closed this May 29, 2022
@chapulina chapulina deleted the scpeters/narrow_namepsace_migration branch May 29, 2022 15:03
@scpeters scpeters restored the scpeters/narrow_namepsace_migration branch May 31, 2022 08:50
@scpeters scpeters deleted the scpeters/narrow_namepsace_migration branch May 31, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina Awaiting requested review from chapulina

@methylDragon methylDragon Awaiting requested review from methylDragon

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @chapulina