Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple console warning messages from Utils.cc printed on same line #1312

Open
scpeters opened this issue Aug 21, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@scpeters
Copy link
Member

Environment

  • OS Version: Ubuntu 20.04
  • Source or binary build? source build of sdf13 as of 7f63d02

Description

  • Expected behavior: one console message should be printed per line
  • Actual behavior: several messages from Utils.cc can be printed on a single line

For example from UNIT_Geometry_TEST in the following jenkins console output:

41: �[1;31mError [Utils.cc:174]�[0m Empty string used when setting a required parameter. Key[uri]�[1;31mError [Utils.cc:174]�[0m Empty string used when setting a required parameter. Key[uri][       OK ] DOMGeometry.ToElement (4 ms)

Steps to reproduce

  1. Search for [Utils.cc in https://build.osrfoundation.org/view/ign-garden/job/sdformat-ci-sdformat13-focal-amd64/78/consoleText

Output

@scpeters scpeters added the bug Something isn't working label Aug 21, 2023
@scpeters
Copy link
Member Author

I believe many of these messages come from enforceConfigurablePolicyCondition in Utils.cc which prints many console messages without a trailing '\n'. There are some sdf::Error objects that have a trailing newline character in their message, but the majority do not.

@azeey azeey moved this from Inbox to To do in Core development Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

1 participant