World: handle name collisions like Model #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
scpeters
force-pushed
the
scpeters/world_frame_name_errors
branch
from
1c92d4f
to
114120d
Compare
scpeters
commented
Aug 21, 2023
| ss << "Frame with name [" << frame.Name() << "] " | ||
| << "in world with name [" << this->Name() << "] " | ||
| << "has a name collision, changing frame name to [" | ||
| << frameName << "]."; |
There was a problem hiding this comment.
in the diff without whitespace, you can see that the '\n' is removed on this line
see also #1312
I can revert this if desired
|
this is a behavior change, so we could consider targeting |
Codecov Report
@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
+ Coverage 87.60% 87.64% +0.04%
==========================================
Files 128 128
Lines 16830 16837 +7
==========================================
+ Hits 14744 14757 +13
+ Misses 2086 2080 -6
|
azeey
approved these changes
Aug 22, 2023
It's probably best if we target |
Signed-off-by: Steve Peters <[email protected]> Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
This is a behavior change. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
scpeters
force-pushed
the
scpeters/world_frame_name_errors
branch
from
c652521
to
756e15b
Compare
Signed-off-by: Steve Peters <[email protected]>
I rebased on |
azeey
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Follow-up to #1293 (comment)
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.