-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced tracking camera and user visualization experience #619
Conversation
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
This is the continuation and expansion of PR #515 |
080d4ed
to
a80b6b8
Compare
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Benjamin Perseghetti <[email protected]>
a80b6b8
to
7037054
Compare
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor questions about removing the follow docs
Signed-off-by: Benjamin Perseghetti <[email protected]>
882f6bb
to
12516de
Compare
@osrf-jenkins run tests |
oh we still need osrf/homebrew-simulation#2656. The windows problem with gz-math3 is known but unrelated to this PR |
@j-rivero Do you know if the homebrew/windows CI ever got resolved? I'll be very elated to get this merged ASAP so I can also target upstream 🥳. |
@osrf-jenkins run tests |
Dismissing already addressed stale review.
🎉 New feature
Summary
I would like to thank NXP for their support in enabling this work.
Depends on:
This adds a new
/gui/track
topic using the CameraTrack message to control multiple types of tracking and associated pgain(s), target(s) and offset(s). Furthermore it publishes a tracking camera status CameraTrack message on/gui/currently_tracked
This also adds an 3 unique follow modes and a tracking mode all able to be set from either the
/gui/track
topic or more ideally from the user gui.The 3 follow modes are in a submenu under the right click top level menu
Follow Options >
and are:Follow - Traditional follow mode where camera follows and tracks the same target.
Free Look - Enables a user to follow a target while still using an input device (IE mouse) to look around.
Look At - Only enabled after already selecting a primary object to follow, this allows a user to track a unique secondary target while following the primary target.
The other right click top level menu item added is
Track
, where the gui camera can be moved anywhere in the simulator but will always track the selected object.These all respect using the escape key to stop any form of tracking.
Test it
Use these changes for collection-harmonic.yaml:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.