Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignition -> Gazebo #396

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Ignition -> Gazebo #396

merged 2 commits into from
Jul 15, 2022

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Jul 14, 2022 •
edited
Loading

🦟 Bug fix

Part of:

Summary

Updated links and naming

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jennuine
update codecov badge
00b0198 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine added tests Broken or missing tests / testing infra QA Quality assurance. labels Jul 14, 2022
@jennuine jennuine requested a review from chapulina July 14, 2022 23:05
@jennuine jennuine self-assigned this Jul 14, 2022
@jennuine jennuine requested a review from mjcarroll as a code owner July 14, 2022 23:05
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #396 (cffad60) into ign-common3 (cff1858) will not change coverage.
The diff coverage is n/a.

❗ Current head cffad60 differs from pull request most recent head 909245f. Consider uploading reports for the commit 909245f to get more accurate results

@@             Coverage Diff              @@
##           ign-common3     #396   +/-   ##
============================================
  Coverage        76.63%   76.63%           
============================================
  Files               73       73           
  Lines            10425    10425           
============================================
  Hits              7989     7989           
  Misses            2436     2436

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff1858...909245f. Read the comment docs.

@jennuine
ignition -> gazebo
909245f 
Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine changed the title Update codecov badge Ignition -> Gazebo Jul 14, 2022
@mjcarroll mjcarroll merged commit 983c5e9 into ign-common3 Jul 15, 2022
@mjcarroll mjcarroll deleted the jennuine/codecov_badge branch July 15, 2022 13:57
luca-della-vedova pushed a commit that referenced this pull request Jul 27, 2022
@jennuine @luca-della-vedova
Ignition -> Gazebo (#396)
cc002f9 
* update codecov badge
* ignition -> gazebo

Signed-off-by: Jenn Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

@jennuine jennuine

Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 QA Quality assurance. tests Broken or missing tests / testing infra
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennuine @mjcarroll @chapulina