Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from source: clarify dependency install step #398

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Oct 2, 2023

🦟 Bug fix

Clarify in response to this question: https://community.gazebosim.org/t/unable-to-install-gazebo-garden-in-ubuntu-20-04/2296

Summary

Clarify how to install dependencies when building from source. I've modified the harmonic folder doc only, so this is marked this as a draft; I will propagate the change to the other folders once the wording has been reviewed.

cc @tfoote

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Copy link
Contributor

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If you aren't in the workspace. The find returns nothing and then sort hangs waiting for input to sort.

Fixes #397

Clarify that the current working directory must be the
workspace containing the Gazebo source code when
running the dependency install step.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters force-pushed the scpeters/src_install_dep_clarify branch from 87567a3 to 0982bfd Compare October 3, 2023 16:22
@github-actions github-actions bot added 🌱 garden Gazebo Garden 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Oct 3, 2023
@scpeters scpeters marked this pull request as ready for review October 3, 2023 16:23
@scpeters
Copy link
Member Author

scpeters commented Oct 3, 2023

I amended the commit to apply the fix to all currently supported versions

@azeey azeey merged commit d1cc55e into master Oct 3, 2023
1 check passed
@azeey azeey deleted the scpeters/src_install_dep_clarify branch October 3, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress 🌱 garden Gazebo Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants